Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #1821548: Add a "diff" of some kind to the CMI UI
In working on #2396473: Add missing RTL rules to System CSS, it became apparent to me that some of the css classes being fixed in the patch could not be found anywhere in core. @YesCT helped me discover @heyrocker commented the same thing in #1821548-49: Add a "diff" of some kind to the CMI UI. Shouldn't these classes be removed from system.diff.css?
- td.diff-prevlink
- td.diff-nextlink
- .diff-inline-metadata
- .diff-inline-legend
- .diff-inline-legend span
- .diff-inline-legend label
- diff-deleted
- diff-changed
- diff-added
- diff-section-title
- diff-content
- .odd
- .even
Beta phase evaluation
Issue category | Task because coding standards |
---|---|
Issue priority | Not critical because coding standards |
Unfrozen changes | Unfrozen because it only changes CSS |
Prioritized changes | The main goal of this issue is code clean-up |
Disruption | Non-disruptive because only unused CSS is being removed |
Comment | File | Size | Author |
---|---|---|---|
#18 | before.png | 19.31 KB | pguillard |
#18 | after.png | 19.21 KB | pguillard |
#10 | unused_css_classes_in_core-2502113-10.patch | 1.62 KB | JMC |
Comments
Comment #1
Alka Kumari CreditAttribution: Alka Kumari as a volunteer commentedComment #2
Alka Kumari CreditAttribution: Alka Kumari as a volunteer commentedComment #3
pguillard CreditAttribution: pguillard commentedthey seem not to be used anywhere indeed
Comment #4
prajaankit CreditAttribution: prajaankit commentedComment #5
LewisNymanI looked for these classes and couldn't find them in core. I think there might be a few more classes that aren't being used in this file:
This can go as well:
Comment #6
pguillard CreditAttribution: pguillard commentedI applied #5
Comment #7
pguillard CreditAttribution: pguillard commentedComment #8
JMC CreditAttribution: JMC commentedReviewing this at DrupalCampNorth sprint today with @LewisNyman.
Everything seems correct except for the references to the odd and even classes don't seem to have been removed in the patch. Lewis said this references the work here #1649780: Remove first/last/odd/even classes in favor of CSS3 pseudo selectors.
I'll try to add this to the patch...
Comment #9
LewisNymanComment #10
JMC CreditAttribution: JMC commentedComment #11
JMC CreditAttribution: JMC commentedComment #12
LewisNymanGreat! Thanks for making these changes. Less CSS!
Comment #13
lauriiiComment #14
alexpottCan we get screenshots before and after of config being diffed through the UI.
Also I don't think we're using...
Comment #15
LewisNymanComment #16
pjbaert@alexpott
After a search, I noticed that there is still a reference to
.diffchange
in the HWLDFWordAccumulator.php fileComment #17
pguillard CreditAttribution: pguillard commentedHere are the screenshots :
Before :
After :
Comment #18
pguillard CreditAttribution: pguillard commentedComment #19
LewisNymanGreat, thanks for adding the screenshots. Setting back to RTBC based on the comment in #16.
Comment #20
alexpottCommitted 346567c and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.