Document SafeMarkup::set in FormCache::loadCachedFormState

Sorry we just need to keep these under 80 characters per line.

+++ b/core/lib/Drupal/Core/Form/FormCache.php
@@ -170,7 +170,8 @@ protected function loadCachedFormState($form_build_id, FormStateInterface $form_
+      // this request. The safety of these strings has already been determined in setCache()
+      // This insures that the strings being passed to this function have been marked as safe.

80 character limit.

+++ b/core/lib/Drupal/Core/Form/FormCache.php
@@ -170,7 +170,9 @@ protected function loadCachedFormState($form_build_id, FormStateInterface $form_
+      //function have been marked as safe.

space pleezy

Merci bien! That works.

+++ b/core/lib/Drupal/Core/Form/FormCache.php
@@ -170,7 +170,9 @@ protected function loadCachedFormState($form_build_id, FormStateInterface $form_
+      // in setCache(). This insures that the strings being passed to this

Sorry nitpick but this should be 'ensures'

I'm wondering do we even need this sentence? Seems a tiny bit redundant the way I'm reading it.

+++ b/core/lib/Drupal/Core/Form/FormCache.php
@@ -170,7 +170,9 @@ protected function loadCachedFormState($form_build_id, FormStateInterface $form_
+      // in setCache(). This insures that the strings being passed to this
+      // function have been marked as safe.

I thought there was $5M liability on this method, insures it correct to me:P

Removed the redundant sentence and clarified the first one.

Thanks @davidhernandez. Just adding some pluralized pronouns and doc standards for methods in comments. AFAIK.

Scratch the first thing, it's 'the list' not 'the safe strings'.

+++ b/core/lib/Drupal/Core/Form/FormCache.php
@@ -169,8 +169,9 @@ protected function loadCachedFormState($form_build_id, FormStateInterface $form_
+      // Retrieve the previously known list of safe strings and store it for
+      // this request. The safety of these strings has already been determined
+      // in ::setCache().

Just semantically, I would go with "Retrieve the safe strings and store them for this request. ..." if that conveys the proper meaning. Does it matter that they were "previously known"?

Simplified the sentence. Lets not bikeshed it.

I'm not sure if the ::setStrings() thing is going to mesh with api.d.o, but this looks good to me now. Small patch but it points to where the safeness of the strings has been determined.

Edit: And not sure it matters since it's an inline comment?

Orange... I mean rtbc

Thanks everyone! As with #2501447: Document SafeMarkup::setMultiple in _batch_page(), we're not going to be able to get around this usage right now, and we do have the existing @todo for the memory implications. So, committed and pushed to 8.0.x.

Re: the ::setCache() bit, api.d.o will indeed not parse it, but I think we said it's okay to use such shorthands in paragraphs of text on the same class. So I think that's okay.