Problem/Motivation

The following class constructor use ModuleHandler instead of ModuleHandlerInterface, adding faulty dependency to ModuleHandler:

  • \Drupal\user\AccountSettingsForm
  • \Drupal\field\FieldStorageConfigStorage

Proposed resolution

They should be changed to use the ModuleHandlerInterface

User interface changes

none

API changes

none

CommentFileSizeAuthor
#1 faulty_dependency_to-2501577-1.patch3.91 KBwillzyx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willzyx’s picture

willzyx CreditAttribution: willzyx commented
FileSize
faulty_dependency_to-2501577-1.patch3.91 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Status: Needs review » Reviewed & tested by the community

+1

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Probably needs a short beta evaluation ...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Fixed

Actually I think using a concrete class when there is an interface for a service is a bug. This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 1fc6e00 and pushed to 8.0.x. Thanks!

  • alexpott committed 1fc6e00 on 8.0.x 
    Issue #2501577 by willzyx: Faulty dependency to ModuleHandler
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Faulty dependency to ModuleHandler » Faulty dependency to ModuleHandler in AccountSettingsForm and FieldStorageConfigStorage
Issue tags: +Novice
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue tags: -Novice

Oh, I thought this was still open.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.