Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
We need an upgrade path from 7.x for the core Syslog module.
Remaining Tasks
There's no real need to migrate any data from syslog. But any variables it maintains need to be moved into configuration.
Contributors
@-enzo- wrote the original migration, and @oadaeh uploaded it; @bdimaggio updated it for HEAD and wrote a test.
git commit -m 'Issue #2500529 by -enzo-, bdimaggio, oadaeh: Upgrade path for Syslog 7.x'
Comment | File | Size | Author |
---|---|---|---|
#39 | interdiff-2500529-37-39.txt | 1.68 KB | phenaproxima |
#39 | 2500529-39.patch | 3.09 KB | phenaproxima |
| |||
#37 | interdiff-2500529-35-37.txt | 3.69 KB | phenaproxima |
#37 | 2500529-37.patch | 2.2 KB | phenaproxima |
#35 | interdiff-2500529-33-35.txt | 1006 bytes | phenaproxima |
Comments
Comment #1
bdimaggioComment #2
bdimaggioOK, got the YAML file together and verified that it works in a D7->D8 migration. Tests are on the way.
Comment #3
bdimaggioGot test together. It fails with a fatal error, but so do the other, preexisting tests I've run (see e.g. MigrateActionConfigsTest and MigrateAggregatorConfigsTest). phenaproxima, do you think the problem is upstream from this work?
Comment #4
bdimaggioDammit. Left a bit of test code in.
Comment #5
phenaproximaChanging status for testbot.
Comment #11
phenaproximaPostponing on #2510072: UTF-8 support in MySQL driver breaks migrate dump files, since tests will not work until that one is committed.
Comment #12
phenaproximaComment #15
bdimaggioOK, got tests working on my end. Crossing fingers...
Comment #16
phenaproxima@bdimaggio -- to automatically test patches, be sure to set the status to "needs review". ;-)
Comment #17
phenaproximaThis needs to have the actual name of the test class. :)
IIRC, MigrateDrupal7TestBase doesn't need to be use'd here, because it's in the same namespace.
Can you make the group
migrate_drupal 7.x
(including the space), for consistency with the other tests in the D7 migration path?Other than these things, it looks good to me!
Comment #18
bdimaggioRrrrright I could see how people would want the actual class name to be here :)
Fixed that, removed the "use" of MigrateDrupal7TestBase, and added 7.x to @group. How's this look?
Comment #19
phenaproximaChanging status for testbot.
Comment #20
phenaproximaMe likely. I declare this RTBC.
Comment #21
bdimaggioI couldn't help looking at it again this morning, and realizing that I wasn't taking advantage of my own $modules property when enabling the syslog module in setUp(). That's fixed now and I will stop fiddling.
Comment #22
phenaproximaLooks okay to me.
Comment #23
phenaproximaAdding contributors and commit message to the IS.
Comment #24
alexpottThis needs to be moved to a template - see #2463909: Migrations should support non-installed default configurations (templates)
Comment #25
alexpottAlso this issue needs to be updated for #2495271: Split the migrate_drupal test suite in to 6.x and 7.x groups
Comment #26
phenaproximaRe-rolled.
Comment #28
phenaproximaChanged test group.
Comment #29
phenaproximaAdded @-enzo- as a contributor, since this migration is originally based on his work in #2382117: Migration Files for Drupal 7 Variables.
Comment #30
phenaproximaComment #31
benjy CreditAttribution: benjy at CodeDrop commentedLooks good.
Comment #32
benjy CreditAttribution: benjy at CodeDrop commentedThis should be static::
Comment #33
phenaproximaCorrected.
Comment #34
phenaproxima@benjy re-RTBCed by way of me. :)
Comment #35
phenaproximaRe-rolled for #2514168: Streamline migrate_drupal integration tests.
Comment #36
xjmTitle was tripping me out.
Comment #37
phenaproximaRe-rolled in accordance with #2533886: [meta] Move module-specific migration support into the particular modules supported.
Comment #38
chx CreditAttribution: chx commentedWe need to set facility in the source so we can actually test it's being migrated. Asserting an empty string doesn't tell us much.
Comment #39
phenaproximaFixed.
Comment #40
chx CreditAttribution: chx commentedThis is a go for now and @phenaproxima will open a bug report because facility is an int. http://man7.org/linux/man-pages/man3/syslog.3.html void openlog(const char *ident, int option, int facility);
Comment #41
alexpottIt's nice since migration code in the module that owns the data. Migrate is not subject to beta evaluation. Committed 97ded67 and pushed to 8.0.x. Thanks!