Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
migration system
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 Jun 2015 at 15:15 UTC
Updated:
8 Aug 2015 at 09:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bdimaggioComment #2
bdimaggioOK, here's the migration yml and test.
Comment #3
bdimaggioA little cleanup on the test...
Comment #4
phenaproximaLooks perfect to me. Thank you, @bdimaggio!
Comment #5
bdimaggioI noticed that I wasn't using my self::$modules when enabling the module in setUp(). That's fixed now.
Comment #6
phenaproximaSeems legit.
Comment #7
phenaproximaAdding credit for @hosef, who authored the original migration in #2409439: Variable to config: dblog.settings [d7].
Comment #8
bdimaggioLast time: I realized that I had
copied and pastedused bold originality to name my test testBookSettings rather than testDblogSettings, which this patch fixes.Comment #9
phenaproximaChanged the test group (apparently spaces matter). Otherwise, this still looks great.
Comment #10
alexpottThis needs to use a migration template now - see https://www.drupal.org/node/2527568
Comment #11
phenaproximaDone.
Comment #12
phenaproximaAdded @-enzo- as a contributor, since the migration is based on his work in #2382117: Migration Files for Drupal 7 Variables.
Comment #13
benjy commentedCan hardly believe you #phenaproxima didn't use the new array syntax ;)
static::
Comment #14
phenaproximaCorrected :)
Comment #15
phenaproxima@benjy gave me his blessing on IRC to re-RTBC this.
Comment #16
phenaproximaRe-rolled after #2514168: Streamline migrate_drupal integration tests.
Comment #17
xjmComment #18
phenaproximaRe-rolled in accordance with #2533886: [meta] Move module-specific migration support into the particular modules supported.
Comment #19
chx commentedassertConfigSchema ? Why does this test do that and no other does ? Do we need to add it to others or do we need to remove from her or is dblog special? I asked alexpott about how much the schema is enforced
so I do not think we need to assertConfigSchema here.
Comment #20
phenaproximaFixed.
Comment #21
chx commentedLooks good.
Comment #22
alexpottMigrate is not subject to beta evaluation. Committed 251ca21 and pushed to 8.0.x. Thanks!