Closed (fixed)
Project:
Google Analytics
Version:
8.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Jun 2015 at 07:53 UTC
Updated:
11 Aug 2015 at 14:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berdirComment #3
hass commentedComment #5
hass commentedAny idea why the uninstall test fails now?
Comment #6
hass commentedThere seems no test.
Comment #7
sasanikolic commentedAdded the test for node tokens.
Comment #8
hass commentedInvalid patch
Comment #9
sasanikolic commentedUhh, sorry. Selected the wrong patch.
Comment #10
berdirThis is the only place where you us $this->nodeType, everything else is hardcoded. I'd just hardcode this as well.
I don't think $node_id and $node_title are used?
Something like "Node tokens are shown" might be more useful as an assertion message?
While we're adding this, might be useful to add an assertRaw() on the frontpage or whatever page we visit above, and make sure that there is no ga('set' for dimension 5 at all, to make sure that we don't print out an empty value.
Comment #12
sasanikolic commentedFixes based on the comments above.
Are the test fails related to this change?
Comment #13
berdirNo, they aren't. Looks good now.
Comment #15
berdirComment #16
hass commentedI was also thinking about the http://cgit.drupalcode.org/google_analytics/tree/google_analytics.module... code that need to be tested. This patch seems to test dimensions only.
Comment #17
berdirI don't think we should be testing that here. That part needs work (at least for comments/concepts.. content_translation in 8.x has no translation sets or multiple nodes.. a different language could have a different URL, though), so it seems like that should be it's own issue to improve those things too.
Why would you want to block additional test coverage on more.. let's get this committed and then we can write more.
Comment #18
hass commentedI have tested this feature a few months ago and it worked. When has it changed that translations of a node are no longer other nodes?
When I reopened the case I only thought about testing lines 150ff...
Comment #19
hass commented