The latest version of jquery.imgareaselect is v1.0.0-rc1, whereas manualcrop is using 0.9.10.

I paged through the diff between them, and there don't appear to be any API changes, just internal changes. Some quick manual testing with manualcrop doesn't show any problems, but it should be tested further!

In any case, my main motivation for doing this is that last odyniec.net (where the 0.9.10 build is hosted) went down last night until today and broke Panopoly builds. This is a pain, because we're working up to a release tomorrow. Also, if it was down when the Drupal.org packager script was building Panopoly, then it could even prevent us from releasing!

I saw an older issues about switching to downloading from GitHub:

#2268447: Download imgareaselect from GitHub

It was marked as "won't fix" because (1) it didn't include the minified version and (2) the file structure was different.

The v1.0.0-rc1 download from GitHub does include the minified version! However, the file structure is different, but I figure that's justified since it's a newer version and it's the upstream author's prerogative to re-organize things. :-)

So, I'm hoping that because of those things, this will be an acceptable change.

I'll upload a patch in a moment (just need the issue number).

Comments

dsnopek’s picture

Status: Active » Needs review
StatusFileSize
new2.09 KB

Patch is attached! Please let me know what you think :-)

dsnopek’s picture

Issue tags: +panopoly
matthijs’s picture

Status: Needs review » Needs work

I guess v1.0.0-rc.1 relies on a newer jQuery version (at least 1.7) because I'm getting following Javascript error:

TypeError: pt.add(...).off is not a function

matthijs’s picture

Status: Needs work » Closed (fixed)
dsnopek’s picture

Ah, sorry, Panopoly uses jquery_update so we have jQuery 1.7. I didn't think to check that!

It definitely makes sense to use a version of jquery.imgareaselect that works with the version of jQuery that ships with Drupal.

Thanks for responding to this so quickly! :-)

smurfxx’s picture

How can I apply this patch to the latest dev version of manual crop?