When loading the page a warning appears in the browser's console:
"Invalid App Id: Must be a number or numeric string representing the application id."

This is because this code from fb_likebox.js:
js.src = "//connect.facebook.net/en_EN/sdk.js#xfbml=1&version=v2.3";

The recommended code from Facebook is:
js.src = "//connect.facebook.net/en_US/sdk.js#xfbml=1&version=v2.3&appId=NNNNNNNNNNNNN";

The plugin still loads.

CommentFileSizeAuthor
#9 fb_likebox-invalid_app_id-2499463-9.patch7.32 KBmfernea
#8 fb_likebox-invalid_app_id-2499463-8.patch7.37 KBmfernea

Comments

mfernea’s picture

mfernea commented
Issue summary: View changes

  • baekelandt committed 8fd9fc4 on 7.x-2.x 
    Issue #2499463: Invalid App Id -> added AppID: 123
baekelandt’s picture

baekelandt commented
Status: Active » Fixed

  • baekelandt committed 962bb0b on 7.x-2.x 
    Issue #2499463: Invalid App Id, Now made a real registered AppId on FB
mfernea’s picture

mfernea commented

I think it would be best if the AppID is configurable.

baekelandt’s picture

baekelandt commented

The App Id is set in the js-file, so I don't know how I can make that accessible through the drupal block configuration structure.
It's the same reason why you can't specify the Page plugin's language in the block configuration, so it's always in English unless you decide to override it.

If somebody has an idea on how to do this, let me know (and if you can maybe provide me with a patch).

mfernea’s picture

mfernea commented
Status: Fixed » Needs work

One solution would be to make the js file use Drupal.settings for that.
This might be a good inspiration: https://www.drupal.org/node/304258
I'll try to find time to create a patch.

mfernea’s picture

mfernea commented
Status: Needs work » Needs review
StatusFileSize
new fb_likebox-invalid_app_id-2499463-8.patch7.37 KB

Here is the patch.

mfernea’s picture

mfernea commented
StatusFileSize
new fb_likebox-invalid_app_id-2499463-9.patch7.32 KB

I left a console.log in the patch from #8. Here is the correct version.

baekelandt’s picture

baekelandt commented

@mfernea thanks for creating a patch and helping to make the most of this module.

baekelandt’s picture

baekelandt commented
Status: Needs review » Fixed
mfernea’s picture

mfernea commented

Cheers! ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.