Thanks for the great distro CommerceGuys!

We have a couple of sites that reverted menu links to point to the CommerceGuys Twitter, FB accounts & reactivated disabled Pinterest links after the most recent update.

I'm guessing this was caused by commerce_kickstart_social.info:

features[menu_custom][] = menu-social-connection
features[menu_links][] = menu-social-connection_follow-us-on-twitter:https://twitter.com/commerceguys
features[menu_links][] = menu-social-connection_like-us-on-facebook:https://www.facebook.com/commerceguys
features[menu_links][] = menu-social-connection_what-we-like-on-pinterest:http://pinterest.com/

Cheers,

Andy

CommentFileSizeAuthor
#5 social_menu_updates-2498645-5.patch1 KBmglaman
#3 social_menu_updates-2498645-3.patch899 bytesmglaman

Comments

bojanz’s picture

bojanz commented

One more side-effect of the Features 2.x conversion...

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue tags: +sprint

Adding to kanban board for review, since it deals with the Features 2.x change.

I think it has to do with this update hook :/ Need to get a PR up and review Travis for upgrade tests, as I feel this was an issue with Features and menu_links in 2.x

/**
 * Rebuild Commerce Kickstart Social to ensure Service Links settings.
 */
function commerce_kickstart_social_update_7200() {
  commerce_kickstart_rebuild_feature('commerce_kickstart_social');
}
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new social_menu_updates-2498645-3.patch899 bytes

GitHub PR: https://github.com/commerceguys/commerce_kickstart/pull/119

Attaching patch.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

Tests are failing with patch on upgrade.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new social_menu_updates-2498645-5.patch1 KB

Giving it another approach.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Wrong approach all over. Issue is setting variable from #2245219: No service links shown in 2.13.

Running tests which change upgrade hook to be scoped to

  if (!variable_get('service_links_node_view_modes')) {
    variable_set('service_links_node_view_modes', array(
      'full' => 'full',
      'teaser' => 0,
      'rss' => 0,
      'token' => 0,
      'product_list' => 0,
    ));
  }

https://travis-ci.org/commerceguys/commerce_kickstart/builds/71091537

  • mglaman committed 41502a0 on 7.x-2.x 
    Merge pull request #119 from mglaman/2498645-social-menu-rebuild-reverts...
  • mglaman committed 7d6dd47 on 7.x-2.x
    Issue #2498645: Social Menu updates links to CommerceGuys
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Fixed upgrade hook to only affect specific variable that needed to be set.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.