Would be nice if the watermark added by the module would be optionally. The js for the watermark seems to be very complicated an needs some rewrite.

CommentFileSizeAuthor
#1 google_cse-watermark-rewrite-2498613-1.patch4.03 KBosopolar

Comments

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Status: Active » Needs review
StatusFileSize
new google_cse-watermark-rewrite-2498613-1.patch4.03 KB

I am not en expert on jquery and I only test this the changes for the free version of Google CSE on Firefox and Chrome. I am not sure if all the selectors from the old code are necessary or correct. For my case it is working (especially as I am not going to use the watermarks anyway, or is it mandatory by Googles Terms of service?).

suncorjohn’s picture

suncorjohn commented

How do I apply this patch? Never implemented a patch before but I would really like to remove the Google branding watermark in the search box.

Thanks-in-Advance,

John

Fixed using the following: https://www.drupal.org/node/1678312

Sakhmed’s picture

Sakhmed commented

osopolar, I have tried to apply your patch. The patch fails

user@server:~/sites/all/modules/google_cse$ patch < file.patch
patching file google_cse.admin.inc
Hunk #1 FAILED at 99.
1 out of 1 hunk FAILED -- saving rejects to file google_cse.admin.inc.rej
patching file google_cse.js
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file google_cse.js.rej
patching file google_cse.module
Hunk #1 FAILED at 217.
1 out of 1 hunk FAILED -- saving rejects to file google_cse.module.rej
osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

Yes I expected this due to the latest changes in the module. You could try to implement the changes of this patch manually. I'll look at this again, when the issue #2547083: [META] Roadmap for a working 2.4 release is fixed and a new stable version 2.4 was published.

malcomio’s picture

malcomio commented
Status: Needs review » Needs work
malcomio’s picture

malcomio commented
Status: Needs work » Closed (duplicate)

Marking as a duplicate of #1168840: Add the option to remove the styles applied in google_cse.js via a settings checkbox, as that issue seems to be more detailed.