Per the analysis at #2485109: Remove any un-used external dependencies, this library is unused in core, so we should remove it before release. The plan was for it to be used as part of #1762204: Introduce Assetic compatibility layer for core's internal handling of assets but that initiative stalled out and was moved to 8.1.x+.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | interdiff.txt | 2.96 KB | star-szr |
| #7 | remove_sdboyer_gliph-2498599-7.patch | 87.91 KB | star-szr |
| #1 | remove-gliph-2498599.patch | 85.08 KB | webchick |
Comments
Comment #1
webchickLet's try this.
Comment #6
star-szrI'm not that familiar with how these patches usually go but there are still traces in core/vendor/composer/installed.json and core/vendor/composer/autoload_namespaces.php.
Going to see if I can address that.
Comment #7
star-szrI ran
composer remove sdboyer/gliphand it spit this out.Comment #8
star-szrInterdiff.
Comment #9
dawehnerThis looks like expected but keep in mind, comitting this breaks contrib using it already.
https://github.com/larowlan/default_content would be one of those examples
Comment #10
cilefen commentedPer #9 it needs a change record.
Comment #11
karolus commentedChange record created here: https://www.drupal.org/node/2537942
Comment #13
karolus commentedTested the patch, but it didn't pass, so will be patching and rerolling.
Comment #15
webchickSorry, was just trying to reproduce that error from before. :)
Comment #17
karolus commentedComment #18
naveenvalechaNeeds reroll b/c some of other issues has been committed #2493911, #2508231 and #2529082 before it
composer remove sdboyer/gliph
Comment #19
naveenvalechaHiding mine patch.seems little bit late to post it.
Thanks karolus for the patch.
Change record has been added https://www.drupal.org/node/2537942
Comment #20
naveenvalechaComment #21
cilefen commented#14 or #16 look fine to me.
Comment #22
webchickExcellent, thanks! I did do the initial roll of this patch, but it's scriptable so I don't think there's a problem with me committing this one.
Committed and pushed to 8.0.x. WOO.
Now, off to close out #2485109: Remove any un-used external dependencies. One step closer to RC1! :)