Per the analysis at #2485109: Remove any un-used external dependencies, this library is unused in core, so we should remove it before release. The plan was for it to be used as part of #1762204: Introduce Assetic compatibility layer for core's internal handling of assets but that initiative stalled out and was moved to 8.1.x+.

Comments

webchick’s picture

Status: Active » Needs review
StatusFileSize
new85.08 KB

Let's try this.

Status: Needs review » Needs work

The last submitted patch, 1: remove-gliph-2498599.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: remove-gliph-2498599.patch, failed testing.

Status: Needs work » Needs review

Cottser queued 1: remove-gliph-2498599.patch for re-testing.

star-szr’s picture

Status: Needs review » Needs work

I'm not that familiar with how these patches usually go but there are still traces in core/vendor/composer/installed.json and core/vendor/composer/autoload_namespaces.php.

Going to see if I can address that.

star-szr’s picture

Status: Needs work » Needs review
StatusFileSize
new87.91 KB

I ran composer remove sdboyer/gliph and it spit this out.

star-szr’s picture

StatusFileSize
new2.96 KB

Interdiff.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This looks like expected but keep in mind, comitting this breaks contrib using it already.

https://github.com/larowlan/default_content would be one of those examples

cilefen’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Per #9 it needs a change record.

karolus’s picture

Status: Needs work » Reviewed & tested by the community

Change record created here: https://www.drupal.org/node/2537942

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: remove_sdboyer_gliph-2498599-7.patch, failed testing.

karolus’s picture

Issue tags: +Needs reroll

Tested the patch, but it didn't pass, so will be patching and rerolling.

webchick’s picture

Sorry, was just trying to reproduce that error from before. :)

The last submitted patch, 7: remove_sdboyer_gliph-2498599-7.patch, failed testing.

karolus’s picture

Status: Needs work » Needs review
Issue tags: -Needs change record, -Needs reroll
StatusFileSize
new87.91 KB
naveenvalecha’s picture

Issue tags: +Needs change record
StatusFileSize
new87.91 KB

Needs reroll b/c some of other issues has been committed #2493911, #2508231 and #2529082 before it

composer remove sdboyer/gliph

naveenvalecha’s picture

Hiding mine patch.seems little bit late to post it.
Thanks karolus for the patch.
Change record has been added https://www.drupal.org/node/2537942

naveenvalecha’s picture

Issue tags: -Needs change record
cilefen’s picture

Status: Needs review » Reviewed & tested by the community

#14 or #16 look fine to me.

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +DrupalGovCon

Excellent, thanks! I did do the initial roll of this patch, but it's scriptable so I don't think there's a problem with me committing this one.

Committed and pushed to 8.0.x. WOO.

Now, off to close out #2485109: Remove any un-used external dependencies. One step closer to RC1! :)

  • webchick committed e64a4c7 on 8.0.x
    Issue #2498599 by Cottser, naveenvalecha, webchick, karolus, cilefen:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.