Reported by NancyDru in #2497753-5: Improve how unmet constraints indicated.

CommentFileSizeAuthor
#1 password_policy-7.x-2.x-unhide_password_input_cursor-2498591-1.patch436 bytesAohRveTPV
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Status: Active » Needs review
FileSize
password_policy-7.x-2.x-unhide_password_input_cursor-2498591-1.patch436 bytes

The following statement seems to cause the problem:

e.stopImmediatePropagation();

I do not know the purpose of that statement. It is neither documented in the code nor the Git history. The constraints display seems to work fine without it. So I would suggest removing it, and if it causes a problem for someone, we'll find out what its purpose is and can re-add it.

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented

Looks good to me. Only one person should RTBC, so I won't.

AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented

Only one person should RTBC, so I won't.

I thought it was OK to set a patch to RTBC so long as you were not the person who authored it. So why do you say that?

RTBC description per https://www.drupal.org/node/156119:

The patch has received a thorough review and test by one or more experienced developers, and they have deemed it as ready to be committed to the project.

In any case, if you are not sure it is ready, Needs Review is fine.

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Status: Needs review » Reviewed & tested by the community

I had always heard that it took two or more. If you're happy with one, then I am too.

  • AohRveTPV committed 3e4bdac on 7.x-2.x 
    Issue #2498591 by AohRveTPV, NancyDru: Cursor not shown in password...
AohRveTPV’s picture

AohRveTPV CreditAttribution: AohRveTPV commented
Status: Reviewed & tested by the community » Fixed

There are few active contributors and this branch is still in alpha, so one seems fine to me. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.