In the 7.x-2.x branch, only one anonymous user can vote per entity, regardless of the user's IP or the settings for votingapi_anonymous_window. That's because the function _fivestar_allow_vote doesn't pass the IP as criterion to votingapi_select_votes for anonymous users. I've attached a patch with a fix for this bug.

CommentFileSizeAuthor
#12 fivestar-2498161-12.patch1.57 KBpifagor
#10 anonymous_vote_with_postmoderation-2498161-10.patch1.37 KBcosolom
#6 fivestar-anonymous_revote-2498161-6.patch584 byteseeg
#3 fivestar-anonymous_revote-2498161-3.patch238 byteseeg
anonymous-revote.patch576 byteseeg

Comments

hver’s picture

hver commented
Status: Active » Needs review

Updating issue status for automatic testing.

Status: Needs review » Needs work

The last submitted patch, anonymous-revote.patch, failed testing.

eeg’s picture

eeg commented
StatusFileSize
new fivestar-anonymous_revote-2498161-3.patch238 bytes

Same patch again, this time it should be applicable (hopefully).

eeg’s picture

eeg commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: fivestar-anonymous_revote-2498161-3.patch, failed testing.

eeg’s picture

eeg commented
Status: Needs work » Needs review
StatusFileSize
new fivestar-anonymous_revote-2498161-6.patch584 bytes

Something went wrong when I've created the patch and I didn't check it before uploading it. So lets go for another try.

eeg’s picture

eeg commented
Component: Documentation » Code
pieterdc’s picture

pieterdc
Primary language Dutch
Location Ghent
commented

I agree 1 allowed anonymous vote per IP address is better than 1 allowed anonymous vote overall. But it still doesn't cut the mustard. I suggest to collaborate on #798790: Option for anonymous votes to use session id in vote_source field to allow 1 anonymous vote per anonymous user session.

dbt102’s picture

dbt102 commented
Status: Needs review » Needs work
cosolom’s picture

cosolom commented
Status: Needs work » Needs review
StatusFileSize
new anonymous_vote_with_postmoderation-2498161-10.patch1.37 KB

I think that your decision about user IP is wrong. You can see problem when anonymous comments published by moderator. And in this case your patch will fail because user is logged in (moderator) but comment still for anonymous user and you rewrite user ip with moderator ip. I propose this patch, but have no possibility test all cases, so i think that this patch is not final. But it work with postmoderate comments and with edited comments

lubwn’s picture

lubwn commented

Patch in #10 works perfectly! Thank you very much!

pifagor’s picture

pifagor commented
StatusFileSize
new fivestar-2498161-12.patch1.57 KB

The problem is that the wrong ones define the user ID. Here is a patch that should fix this problem