PSR-7 support for ControllerResolver

I'm not sure if this the best solution.

@Crell If I understand the situation we would have to not type hint the request in function signatures in ControllerResolver but then check the request type in the function logic.

More like this ?

Let's expand our unit test here :)

+++ b/core/lib/Drupal/Core/Controller/ControllerResolver.php
@@ -135,6 +147,9 @@ protected function doGetArguments(Request $request, $controller, array $paramete
+        $arguments[] = $this->httpFoundationFactory->createRequest($request);

The problem here is that a Symfony Request is the wrong parameter type. We need a request of type Psr\Http\Message\ServerRequestInterface.

+++ b/core/lib/Drupal/Core/Controller/ControllerResolver.php
@@ -135,6 +147,9 @@ protected function doGetArguments(Request $request, $controller, array $paramete
       }
+      elseif ($param->getClass() && $param->getClass()->name === 'Psr\Http\Message\ServerRequestInterface') {
+        $arguments[] = $this->httpFoundationFactory->createRequest($request);
+      }

I don't get it at all ... the point is to be able to pass along the server request to the controller, we don't need to convert anything.

Now with the right injecten and some unit tests.

OH I take back #11, that was BS.

1. +++ b/core/lib/Drupal/Core/Controller/ControllerResolver.php
   @@ -60,7 +70,7 @@ public function getControllerFromDefinition($controller, $path = '') {
          elseif (method_exists($controller, '__invoke')) {
   -        return new $controller;
   +        return new $controller();
          }
   

   That change is wrong. The result of a controller should not be created in the controller resolver.

2. +++ b/core/lib/Drupal/Core/Controller/ControllerResolver.php
   @@ -115,7 +125,7 @@ protected function createController($controller) {
    
   -    return array($controller, $method);
   +    return [$controller, $method];
      }
   
   @@ -124,7 +134,7 @@ protected function createController($controller) {
   -    $arguments = array();
   +    $arguments = [];
   

   I'd suggest you to not try to fix all those small things please. Please try to keep in mind that you should optimize for reviewability.

So =)

Thank you!

Just a random nitpick :P

+++ b/core/tests/Drupal/Tests/Core/Controller/ControllerResolverTest.php
@@ -41,6 +43,13 @@ class ControllerResolverTest extends UnitTestCase {
+   * @var \Symfony\Bridge\PsrHttpMessage\HttpMessageFactoryInterface;

We don't use a semicolon at the end here

Yeah!

+++ b/core/lib/Drupal/Core/Controller/ControllerResolver.php
@@ -38,12 +40,20 @@ class ControllerResolver extends BaseControllerResolver implements ControllerRes
    * @param \Drupal\Core\DependencyInjection\ClassResolverInterface $class_resolver
    *   The class resolver.
    */
-  public function __construct(ClassResolverInterface $class_resolver) {
+  public function __construct(HttpMessageFactoryInterface $http_message_factory, ClassResolverInterface $class_resolver) {

Need to document the new parameter and I think the new capability should be listed on the ControllerResolver as this is another added behaviour.

@Crell I think we should document PSR-7 support in menu.api.php

I really like the documentation. Its helpful. I was wondering whether we should rearrange things a bit.

Thanks for improving the documentation. Committed c176ab7 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.