Closed (fixed)
Project:
Examples for Developers
Version:
8.x-1.x-dev
Component:
Block Example
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 May 2015 at 15:03 UTC
Updated:
19 Aug 2015 at 19:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
willzyx commentedComment #3
mile23Hey, looks great, thanks.
Just one thing:
Since there's only one test method, let's just move the user creation and login into the test method, and just delete our
setUp()override.Comment #4
willzyx commentedComment #6
willzyx commentedcopy(/var/lib/drupaltestbot/sites/default/files/checkout/sites/simpletest/487467/settings.php): failed to open stream: No such file or directorycopy('/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/default.settings.php', '/var/lib/drupaltestbot/sites/default/files/checkout/sites/simpletest/487467/settings.php')Comment #8
mile23What are those error messages about?
Comment #9
willzyx commentedare about the failing test in #5
Comment #10
mile23Ah, OK, I see. Thanks.
Comment #11
mile23I can't get #4 to pass locally, so I'll try the testbot here.
Note that there's a branch blocker on block_example that I'm trying to fix, so that might represent an API change not present in the code base or in the patch.
Comment #14
willzyx commentedMile23 #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block changes a bit the block layout page. The attached patch should solves the issue with test
there is a open issue? if you are interested I can help
Comment #15
willzyx commentedthe interdiff
Comment #17
willzyx commented@Mile23 you just committed the change that I did in the test :) . This is a simple reroll
Comment #18
mile23Thanks, @willzyx. Generally branch blockers don't get issues unless they're majorly crazy or need community input. In this case it was just the URL change.
This looks like all best-practices stuff, which is good. Committed and pushed.