Canceled registrations count towards event count (so you can hit capacity early!)

Currently, in the default configuration, registrations with a state of 'canceled' will be included in the event count. If your event has a capacity set, then it'll stop letting people register before having enough active registrations!

The right thing to do, would be to only include states which are 'Active' or 'Held' in the event count.

There is some code in registration_event_count() which looks like it was intended to do exactly that:

    $active_held_states = registration_states(array('held' => TRUE, 'active' => TRUE));
    if (!empty($active_held_states)) {
      $query->condition('state', $active_held_states, 'IN');
    }

However, $active_held_states will always be an empty array, because that call to registration_states() is attempting to return states which are BOTH active and held, which is not possible.

Also, registration_states() returns full registration state entities, not just the names, so even if it did return the right states, the query wouldn't be right anyway.

I'll post a patch to fix in a moment!