Problem/Motivation

The 'edit' link to a taxonomy term edit form is checked incorrectly. This is results in a link to a 403 page for users with insufficient permissions.

Proposed resolution

Correct the existing check for editing permission.

Remaining tasks

  1. Write a patch
  2. Review

User interface changes

The 'edit' link no longer shows for users with insufficient editing permissions.

API changes

None

CommentFileSizeAuthor
#1 taxonomy_access_fix-edit_permission_check-2497111-1.patch866 bytesidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr’s picture

idebr CreditAttribution: idebr commented
Status: Active » Needs review
FileSize
taxonomy_access_fix-edit_permission_check-2497111-1.patch866 bytes

Attached patch fixes the 'edit' permission check in taxonomy_overview_terms()

rudiedirkx’s picture

rudiedirkx CreditAttribution: rudiedirkx commented

According to my calculations $item is an array, because $item = &$form[$item];. You're using it as a string (element name). It used to be a string: foreach (element_children($form) as $item) {

So what's up?

rudiedirkx’s picture

rudiedirkx CreditAttribution: rudiedirkx commented
Status: Needs review » Needs work
idebr’s picture

idebr CreditAttribution: idebr commented

According to my calculations $item is an array, because $item = &$form[$item];

That is true for branch 7.x-1.x, but not in 7.x-2.x:
7.x-1.x: http://cgit.drupalcode.org/taxonomy_access_fix/tree/taxonomy_access_fix....
7.x-2.x: http://cgit.drupalcode.org/taxonomy_access_fix/tree/taxonomy_access_fix....

rudiedirkx’s picture

rudiedirkx CreditAttribution: rudiedirkx commented
Status: Needs work » Fixed

Of course you're right =) Fixed.

  • rudiedirkx committed 77f8f22 on 7.x-2.x authored by idebr 
    Issue #2497111 by idebr: Term 'edit' permission check on vocabulary term...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.