In order to set Domain Access-specific settings for menu_block_admin_settings_form() I had to implement Drupal's system_settings_form().

This also adds simple variable_set support for all keys in $form_state['values'], which should be leveraged too but I disabled that in the following patch to have a minimal impact.

On a side note: variable_del() should never be used outside hook_uninstall() because you can't add deleted variables to Features.

CommentFileSizeAuthor
#3 menu_block-system_settings_form-2497041-3.patch1.54 KBmrharolda
#1 menu_block-system_settings_form-2497041-1.patch905 bytesmrharolda

Comments

mrharolda’s picture

mrharolda commented
Status: Active » Needs review
StatusFileSize
new menu_block-system_settings_form-2497041-1.patch905 bytes
mrharolda’s picture

mrharolda commented
Status: Needs review » Needs work

This isn't sufficient for Domain Access module; it should not empty the $form_state['values'].

mrharolda’s picture

mrharolda commented
Status: Needs work » Needs review
StatusFileSize
new menu_block-system_settings_form-2497041-3.patch1.54 KB

Here's a patch that fully uses system_settings_form() and system_settings_form_submit(), and 100% supports implementations like the domain specific settings in Domain Access.

I also removed the variable_del() call to fully support Features.

spadxiii’s picture

spadxiii commented
Status: Needs review » Reviewed & tested by the community

Works great! :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Yay, this is great!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Committed #3 to 7.x-2.x.

  • Dave Reid committed 80d82dd on 7.x-2.x authored by MrHaroldA 
    Issue #2497041 by MrHaroldA: Converted menu_block_admin_settings_form()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.