Modify Drupal strength level message [#2496823]

Can we please change the message found in drupal_strength.inc from this:

'message' => t('Password must match a Drupal strength level.'),

to this:

'message' => t('Password must match a strength level.'),

Users have no idea what a "Drupal strength level" is, and in fact many don't even know what a "Drupal" is. :-)

Comment	File	Size	Author
#1	password_policy-7.x-2.x-improve_drupal_strength_message-2496823-1.patch	615 bytes	AohRveTPV
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

AohRveTPV CreditAttribution: AohRveTPV commented 29 May 2015 at 07:49

Status:

Active

» Needs review

File	Size
password_policy-7.x-2.x-improve_drupal_strength_message-2496823-1.patch	615 bytes

Good suggestion. I agree, the word "Drupal" should not be exposed to users.

Comment #2

ron_s CreditAttribution: ron_s commented 29 May 2015 at 11:07

Thanks for the speedy response!

Comment #3

ron_s CreditAttribution: ron_s commented 29 May 2015 at 11:09

Also I can confirm the patch applies cleanly and have reviewed. :)

Comment #4

AohRveTPV CreditAttribution: AohRveTPV commented 30 May 2015 at 19:51

The message seems sort of vague. I wonder if "calculated strength level" might be more informative than "strength level".

In any case, the word Drupal clearly needs to go, so committing.

Comment #5

30 May 2015 at 19:53

AohRveTPV committed 61d4634 on 7.x-2.x

Issue #2496823 by AohRveTPV: Modify Drupal strength level message

Comment #6

AohRveTPV CreditAttribution: AohRveTPV commented 30 May 2015 at 21:17

Status:

Needs review

» Fixed

Comment #7

AohRveTPV CreditAttribution: AohRveTPV commented 30 May 2015 at 21:19

Reverting and recommitting to also credit ron_s.

Comment #8

30 May 2015 at 21:20

AohRveTPV committed 34adf22 on 7.x-2.x

Issue #2496823 by AohRveTPV, ron_s: Modify Drupal strength level message

AohRveTPV committed 6a86a44 on 7.x-2.x

Revert "Issue #2496823 by AohRveTPV: Modify Drupal strength level...

Comment #9

ron_s CreditAttribution: ron_s commented 31 May 2015 at 00:37

Thanks... I do agree the message is vague. In a certain way I wondered why it's shown at all.

When the message says "Password must have at least 1 digit(s)," there is a very clear course of action for the user.

For Drupal strength level, no definition is presented. Users don't know what they are supposed to do to meet the criteria, and I don't think it would be wise to share all the details. There are already too many details presented.

Not to overly analyze, but how about a checkbox on the subform, and default of disabled?

  $sub_form['drupal_strength_fieldset']['strength_message_display'] = array(
    '#type' => 'checkbox',
    '#title' => t('Display Drupal strength level policy message when password policy requirements are shown.'),
    '#default_value' => $constraint->config['strength_message_display'],
  );