In PHP versions prior to 5.6.0, there was a bug which meant that CURLOPT_FOLLOWLOCATION did not work with either safe mode or open_basedir (see https://bugs.php.net/bug.php?id=65646). Feeds works around this bug by preventing the use of cURL if either safe mode or open_basedir are enabled.

However, as of PHP 5.6.0, the PHP cURL extension works if open_basedir is enabled (see http://php.net/ChangeLog-5.php#5.6.0). So for PHP 5.6.0 and above, Feeds is incorrectly preventing the use of cURL.

Comments

diarmy’s picture

This patch allows the use of cURL in php 5.6.0 even if open_basedir is enabled. For versions below this, the use of cURL with open_basedir or safe mode enabled is still not permitted.

diarmy’s picture

Status: Active » Needs review
twistor’s picture

Cleaned up a few things, looks good. Just checking the testbot.

Status: Needs review » Needs work

The last submitted patch, 3: feeds-permit-curl-in-php5.6.0-and-above-2496735-3.patch, failed testing.

twistor’s picture

Status: Needs work » Needs review
StatusFileSize
new1.23 KB

  • twistor committed f82a966 on 7.x-2.x authored by diarmy
    Issue #2496735 by twistor, diarmy: For PHP 5.6.0 and above, Feeds should...
twistor’s picture

Assigned: diarmy » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.