Missing entry in the reformated maintainers.txt.

CommentFileSizeAuthor
#10 menu_subsystem-maintainers-2496367-10.patch964 bytesNikolay Shapovalov
#6 menu_subsystem-maintainers-2496367-5.patch942 bytesashutoshsngh
#4 menu_subsystem-maintainers-2496367-4.patch658 bytesjibran
core-maintainers-menu.patch327 bytesnod_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ as a volunteer commented
Issue tags: +Trivial patch of the month
Parent issue: » #2050477: [META] Identify component maintainers for components with no maintainer listed in MAINTAINERS.txt
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

pwolanin and myself are probably a good fit.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

+1 for #2

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Title: Add ? as Menu subsystem maintainer » Add dawehner and pwolanin as Menu subsystem maintainer
Issue tags: -Trivial patch of the month
FileSize
menu_subsystem-maintainers-2496367-4.patch658 bytes

Here we go.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Needs work 
+++ b/core/MAINTAINERS.txt
@@ -159,6 +159,8 @@ Migrate
 Menu system

Menu comes before "Migrate" in alphabetical order so it should be moved up.

ashutoshsngh’s picture

ashutoshsngh CreditAttribution: ashutoshsngh at Srijan | A Material+ Company commented
Status: Needs work » Needs review
FileSize
menu_subsystem-maintainers-2496367-5.patch942 bytes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Needs work
Issue tags: +Novice 
+++ b/core/MAINTAINERS.txt
@@ -360,6 +362,7 @@ Menu UI module
 Menu Link module
+- Daniel Wehner 'dawehner' https://www.drupal.org/u/dawehner
 - Peter Wolanin 'pwolanin' https://www.drupal.org/u/pwolanin

How could I have missed this? "Menu Link" should come before "Menu UI".

pwolanin’s picture

pwolanin CreditAttribution: pwolanin at Acquia commented

Shoudl we rename or be more specific about what "Menu System" means? I guess menu link, local task, and local action plugins?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented

Shoudl we rename or be more specific about what "Menu System" means? I guess menu link, local task, and local action plugins?

That is a good idea, well, don't we have that defined as some form of docs internally already?

Note: There is also no such thing anymore which is called menu_link module. There is menu_ui and menu_link_content, I guess we should update it

Nikolay Shapovalov’s picture

Nikolay Shapovalov
Primary language Russian
CreditAttribution: Nikolay Shapovalov commented
Status: Needs work » Needs review
FileSize
menu_subsystem-maintainers-2496367-10.patch964 bytes

Change "Menu Link module" to "Menu link content module".
Put Menu UI after Menu link content module.

iMiksu’s picture

iMiksu
Location Finland
CreditAttribution: iMiksu as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Issue tags: -Novice +Project governance

+1. This isn't so much adding new maintainers as it is reflecting a long-standing reality. Thanks @dawehner and @pwolanin :)

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Spot on @tim.plunkett. Thank you @dawehner and @pwolanin.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Assigned: Unassigned » Dries

+1. No, +lots!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: menu_subsystem-maintainers-2496367-10.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Needs work » Reviewed & tested by the community

Obviously unrelated.

Dries’s picture

Dries CreditAttribution: Dries commented
Assigned: Dries » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed. @dawehner and @pwolanin; thanks for all your continued help with the menu system!

  • Dries committed 0df55ad on 8.0.x 
    Issue #2496367 by jibran, nod_, zniki.ru, ashutoshsngh: Add dawehner and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.