Add simplenews_demo test to module.

1. +++ b/config/schema/simplenews.schema.yml
   @@ -232,6 +232,16 @@ field.value.simplenews_subscription:
      mapping:
   +    cache:
   +      type: mapping
   +      label: Cache
   +      mapping:
   +        max-age:
   +          type: integer
   +          label: Maximum Age
   +        contexts:
   +          type: sequence
   +          label: Contexts
        newsletters:
   

   At least the contexts setting no longer exists and should be removed.

2. +++ b/modules/simplenews_demo/config/install/block.block.simplenewssubscription.yml
   @@ -3,8 +3,8 @@ status: true
    dependencies:
      module:
        - simplenews
   -  theme:
   -    - bartik
   +#  theme:
   +#    - bartik
    id: simplenewssubscription
   

   This is obviously not a proper fix. But it shows the problem, we can't realy on this being available in the test. Except if we make it so.

   I think we should move this into _install() and set the theme dynamically to the current default theme which you can get from system.theme:default config.

   It also means that we need to check that those blocks exists, because this change means that they don't I think.

3. +++ b/modules/simplenews_demo/src/Tests/SimplenewsDemoTest.php
   @@ -0,0 +1,63 @@
   +  protected function testInstalled() {
   +    $this->drupalGet('/admin/config/services/simplenews');
   

   no leading / in drupalGet(). More below.

4. +++ b/modules/simplenews_demo/src/Tests/SimplenewsDemoTest.php
   @@ -0,0 +1,63 @@
   +    $this->drupalGet('/admin/content/simplenews');
   +    $this->assertRaw(t('Newsletter issue sent to 2 subscribers.'));
   +    $this->assertRaw(t('Newsletter issue is pending, mails sent out of 3.'));
   +    $this->assertRaw(t('Newsletter issue is pending, mails sent out of 1.'));
   

   We should also assert on the node titles I think.

   This text actually looks brong, there should be a number there (X sent out of 3)

5. +++ b/src/Tests/SimplenewsTestSubscriptionOutput.php
   @@ -15,6 +15,13 @@ namespace Drupal\simplenews\Tests;
   +   * Modules to enable.
   +   *
   +   * @var string[]
   +   */
   +  public static $modules = array('simplenews', 'simplenews_scheduler', 'simplenews_demo');
   +
   

   Should be reverted.

There are parts in this patch that are not related to this issue.

As a followup: The demo module still lacks a general intro node (sticky) with some links / references to relevant parts in the application. Example: collect_demo

Yeah. Committed.

Please create a followup about this bartik dependency problem.

@LKS90 - Please, it would be great if you could paste the link to the followup issues next time.

1. +++ b/modules/simplenews_demo/src/Tests/SimplenewsDemoTest.php
   @@ -0,0 +1,73 @@
   +namespace Drupal\simplenews_demo\Tests;
   +
   +use Drupal\search_api\Tests\WebTestBase;
   +
   +/**
   + * Tests the demo module for Simplenews.
   + *
   + * @group simplenews
   + */
   +class SimplenewsDemoTest extends WebTestBase {
   

   Why on earth is this extending from WebTestBase in search_api and how were the tests here green?

   Testbot is completely broken right now..

2. +++ b/modules/simplenews_demo/src/Tests/SimplenewsDemoTest.php
   @@ -0,0 +1,73 @@
   +    // Install bartik theme.
   +    \Drupal::service('theme_handler')->install(array('bartik'));
   +    $theme_settings = $this->config('system.theme');
   +    $theme_settings->set('default', 'bartik')->save();
   +    // Log in with all relevant permissions.
   +    $this->drupalLogin($this->drupalCreateUser(['administer simplenews subscriptions', 'send newsletter', 'administer newsletters', 'administer simplenews settings']));
   

   If you enable bartik and then manually install simplenews_demo then the dependency stuff should be working fine...

Re-opening this, we should either fix this asap or revert.

The previous patch has not been reverted, you need to do a diff against that, this won't apply.

Committed.