Opened as followup to #2420737: Differences in dynamic language names are confusing in views, content, etc. based on @xjm:

+++ b/core/modules/views_ui/src/Tests/ViewEditTest.php
@@ -138,6 +138,73 @@ public function testEditFormLanguageOptions() {
+        // Test that the order of the language list is similar to other language
+        // lists, such as in Views UI.

Minor: This is the test for the Views UI. I think this comment should be "in the content translation settings" or such? I was going to just fix this on commit but my brain has melted and I also am not sure of the proper label for the... thingy. So this is a tiny (and novice-friendly) followup to make.

Beta phase evaluation

-

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because comment is incorrect in the test (not a functional bug).
Issue priority Minor because its a comment in a test.
Unfrozen changes Unfrozen because it only changes documentation.
Disruption Not disruptive. A comment in a test.
CommentFileSizeAuthor
#1 2494915.patch744 bytesgábor hojtsy

Comments

gábor hojtsy’s picture

Status: Active » Needs review
StatusFileSize
new744 bytes

That is the right text for this one yup.

cilefen’s picture

Issue tags: +Needs beta evaluation
gábor hojtsy’s picture

Priority: Normal » Minor
Issue summary: View changes
Issue tags: -Needs beta evaluation

@cliefen: really, for one line of comment change in a test? Not sure it makes it more clear :D

cilefen’s picture

@Gábor Hojtsy It's your call. We are trying to get more novices involved, and different contributors have different trust levels with the committers.

cilefen’s picture

Issue summary: View changes
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

This is correct.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed dcd6fa3 on 8.0.x
    Issue #2494915 by Gábor Hojtsy: Fix comment in ViewEditTest.php
    
gábor hojtsy’s picture

Issue tags: -sprint

Superb, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.