Problem/Motivation

From @alexpott's review in #2304461-141: KernelTestBaseTNG™:

+++ b/core/tests/Drupal/Tests/KernelTestBase.php
@@ -0,0 +1,1178 @@
+  protected $runTestInSeparateProcess = TRUE;
Nice - I didn't know this was possible - we should have a followup to do the same for BrowserTestBase. And @dawehner thank you for leaving this in. Regardless of the debate about whether this is correct the fact that run-tests.sh runs every test in a separate process means that at least this is making the PHPUnit runner behave the same way.

Proposed resolution

Add protected $runTestInSeparateProcess = TRUE; to BrowserTestBase.

Remaining tasks

- Patch
- Review

User interface changes

None

API changes

CommentFileSizeAuthor
#8 2494735-8.patch2.38 KBhussainweb
#8 interdiff-5-8.txt2.21 KBhussainweb
#5 2494735-5.patch583 byteshussainweb
#5 interdiff.txt555 byteshussainweb
#3 2494735-3.patch582 byteshussainweb

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Nice

hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes

Updating the IS for clarity.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 2494735-3.patch582 bytes

I am guessing this is the only thing required?

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work

@hussainweb: yes I think so.

One minor issue with the documentation:
+ * Kernel tests are run in separate processes to prevent collisions between
Should be "Browser tests".

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt555 bytes
new 2494735-5.patch583 bytes

Thanks @tstoeckler for the review. Fixed.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks perfect for me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
 * All BrowserTestBase tests must have two annotations to ensure process
 * isolation:
 * - @runTestsInSeparateProcesses
 * - @preserveGlobalState disabled

From Drupal\simpletest\BrowserTestBase - lets remove this and the annotations from the tests and add in the protected property that can disable preserving global state.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-5-8.txt2.21 KB
new 2494735-8.patch2.38 KB

Fixed for reviews in #7.

bojanz’s picture

bojanz commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 34fda85 and pushed to 8.0.x and 8.1.x. Thanks!

diff --git a/core/modules/simpletest/src/BrowserTestBase.php b/core/modules/simpletest/src/BrowserTestBase.php
old mode 100644
new mode 100755

diff --git a/core/modules/simpletest/tests/src/Functional/BrowserTestBaseTest.php b/core/modules/simpletest/tests/src/Functional/BrowserTestBaseTest.php
old mode 100644
new mode 100755

diff --git a/core/tests/Drupal/Tests/Core/Form/FormCacheTest.php b/core/tests/Drupal/Tests/Core/Form/FormCacheTest.php
old mode 100644
new mode 100755

Fixed this on commit... patches should not change file modes to 755.

  • alexpott committed 224c447 on 8.1.x 
    Issue #2494735 by hussainweb: add $runTestInSeparateProcess = TRUE for...

  • alexpott committed 34fda85 on 
    Issue #2494735 by hussainweb: add $runTestInSeparateProcess = TRUE for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.