Follow-up to #2383871: Spellchecking Drupal - PHP

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because this is about spelling mistakes.
Issue priority Not critical because these are only 3 minor issues in the code. Also, the affected strings are not very exposed to the user (they are tests or it is not exposed at all)
Unfrozen changes Unfrozen because it only changes (translatable) strings and tests.
Disruption Not disruptive, fixing these 3 typos is not going to break anything
CommentFileSizeAuthor
#19 follow_up_to-2494313-19.patch2.12 KBsumitmadan
#14 follow_up_to-2494313-14.patch2.11 KBsumitmadan
#3 2494313-3.patch2.11 KBpere orga
#1 2494313.patch858 bytespere orga

Comments

pere orga’s picture

pere orga
Primary language Catalan
commented
StatusFileSize
new 2494313.patch858 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2494313.patch, failed testing.

pere orga’s picture

pere orga
Primary language Catalan
commented
Status: Needs work » Needs review
StatusFileSize
new 2494313-3.patch2.11 KB

Attached patch fixes 3 typos

aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Reviewed & tested by the community

Looks correct. No functional implications for these changes.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Thanks! Guess a couple were missed.

As I said in #2383871-35: Spellchecking Drupal - PHP, we need to do a beta evaluation on normal and minor tasks. Edit: sorry, I should have provided references. See https://www.drupal.org/core/beta-changes and https://www.drupal.org/contributor-tasks/update-allowed-beta.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs beta evaluation
xjm’s picture

xjm
she/her
Primary language English
commented 
+++ b/core/modules/migrate_drupal/config/install/migrate.migration.d6_system_maintenance.yml
@@ -1,5 +1,5 @@
-label: Drupal 6 maintainence page configuration
+label: Drupal 6 maintenance page configuration

Also I'm concerned as to what this is actually changing -- where is this label used?

aohrvetpv’s picture

aohrvetpv commented
Status: Needs work » Postponed
Issue tags: -Spelling mistake, -Needs beta evaluation

Postponed per https://www.drupal.org/core/beta-changes.

pere orga’s picture

pere orga
Primary language Catalan
commented
Issue summary: View changes
Status: Postponed » Needs review
Issue tags: +Spelling mistake

Also I'm concerned as to what this is actually changing -- where is this label used?

This label was introduced in #2121299: Migrate in Core: Drupal 6 to Drupal 8 (patch https://www.drupal.org/files/issues/2121299.35.patch) as part of the provided mappings of the source and destination fields. The label does not come from migrate and migrate_d2d projects.

As there's currently no UI provided and I can't see the strings exposed via Drush, I guess this is currently not used (obviously the label may be useful to document the mapping).

Postponed per https://www.drupal.org/core/beta-changes.

Can you be more specific why do you think this should be postponed? To me it should be the same than #2383871: Spellchecking Drupal - PHP.

Trying to add beta evaluation.

pere orga’s picture

pere orga
Primary language Catalan
commented
Issue summary: View changes
pere orga’s picture

pere orga
Primary language Catalan
commented
Related issues: +#2494319: Follow up to Spellchecking Drupal - Comments

Adding #2494319: Follow up to Spellchecking Drupal - Comments as a related issue.

aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Reviewed & tested by the community

Can you be more specific why do you think this should be postponed? To me it should be the same than #2383871: Spellchecking Drupal - PHP.

I was just posting the following to correct myself:

Actually these are probably unfrozen changes per https://www.drupal.org/core/beta-changes#unfrozen. Two changes pertain to automated tests (unfrozen), and the other pertains to D6->D8 migration (unfrozen).

Looks good to me. Setting back to RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2494313-3.patch, failed testing.

sumitmadan’s picture

sumitmadan commented
Status: Needs work » Needs review
StatusFileSize
new follow_up_to-2494313-14.patch2.11 KB

Rerolled the patch with latest code.

Pere Orga queued 3: 2494313-3.patch for re-testing.

The last submitted patch, 3: 2494313-3.patch, failed testing.

pere orga’s picture

pere orga
Primary language Catalan
commented
Status: Needs review » Reviewed & tested by the community

Thanks sumitmadan.

Setting it to RTBC as per #12

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: follow_up_to-2494313-14.patch, failed testing.

sumitmadan’s picture

sumitmadan commented
Status: Needs work » Needs review
StatusFileSize
new follow_up_to-2494313-19.patch2.12 KB

File path is changed. Rerolled against the latest code. :)

pere orga’s picture

pere orga
Primary language Catalan
commented
Status: Needs review » Reviewed & tested by the community

:)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d4047ab and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

+++ b/core/modules/migrate_drupal/config/optional/migrate.migration.d6_system_maintenance.yml
@@ -1,5 +1,5 @@
-label: Drupal 6 maintainence page configuration
+label: Drupal 6 maintenance page configuration

This is used on configuration translation forms. It's good to fix it.

  • alexpott committed d4047ab on 8.0.x 
    Issue #2494313 by Pere Orga, sumitmadan: Follow up to Spellchecking...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.