Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up from #2235081: Update jquery_update to version 2.5.
I don't think we can make the default in panopoly_core be higher than 1.7 since there are still lots of contrib modules that fail with jQuery versions above 1.7, and we just don't want to take on that extra support burden.
However! What I think we should do is move this variable from strongarm to defaultconfig. That way it's set at install, but site builders can change it without the Feature becoming overridden. And it would allow a child distribution to set the variable in strongarm (which overrides defaultconfig) and allow other distributions to have a default that's higher than 1.7.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | jquery_strongarm-2492877-7.patch | 2.9 KB | Albert Volkman |
Comments
Comment #1
RobLoachStill needs jQuery Update >=2.5.
Comment #2
RobLoachComment #3
sonictruth CreditAttribution: sonictruth at Kalamuna commentedI have done some testing with Panopoly 1.21 and jQuery update 7.x-3.0-alpha2 with Bartik and Kalatheme 3—things are looking promising.
The following things were identified as problem areas but they now are happy:
• IPE
• wysiwyg
• features listing page
• Views UI
This testing was with jQuery 1.11 with jQuery Migrate OFF.
jQuery 1.8 seems fine as well.
Comment #4
sonictruth CreditAttribution: sonictruth at Kalamuna commentedI've come across some issues:
• Views: Click a field name to configure the field settings. Click "style settings" and tick customize field html. No html element select is revealed. This happens with jQuery 1.11, 1.10, 1.9. 1.8 is happy.
• Panels: When clicking 'Make this reusable' the 'Admin Title' field doesn't show up. This seems to happen with any fields in the pane editor that are supposed to show hidden content. This happens with jQuery 1.11, 1.10, 1.9. 1.8 is happy.
Note that turning on jquery_migrate made all these problems disappear.
Comment #5
dsnopekI don't think we can make the default in panopoly_core be 1.11 since there are still lots of contrib modules that fail with jquery versions above 1.7, and we just don't want to take on that extra support burden.
However! What I think we should do is move this variable from strongarm to defaultconfig. That way it's set at install, but site builders can change it without the Feature becoming overridden. And it would allow a child distribution to set the variable in strongarm (which overrides defaultconfig) and allow other distributions to have a default that's higher than 1.7.
Updating issue title and summary.
Comment #6
sonictruth CreditAttribution: sonictruth at Kalamuna commented++
This sounds like a good compromise.
Comment #7
Albert Volkman CreditAttribution: Albert Volkman commentedSomething like this?
Comment #8
dsnopekThanks for the patch! I applied it and did a fresh install - all worked as expected. Committed!