Update jquery_update to version 2.5

Patch is attached - I haven't done any testing yet.

Did some manual testing: mainly messing with widgets (like Spotlight) and live preview which I know uses lots of Javascript. Everything seemed to work! So, I've committed - let's see what happens with the automated tests:

https://travis-ci.org/panopoly/panopoly/builds/22842735

Of course, I didn't try the Video widget! Here is a bug caused by this update:

#2245133: Media Browser appears underneath the CTools dialog

This version of jquery_update switches from jQuery UI 1.8 to 1.10 - which has a number of incompatibilities with Media 2.x:

#2245143: Media Browser appears underneath CTools dialog and Navbar with jquery_update 2.4
#1957812: Media Browser isn't resized when clicking on tabs (jQuery UI 1.10 incompatibility)

For the time being, I'm going to revert this upgrade. Some work will need to happen in Media before we can do it.

@RobLoach: The problem described here is about updating jQuery UI from 1.8 to 1.10 - not about an increase in the jQuery version. I think one of these issues would be more appropriate:

#2032127: Update jquery_update_version to jQuery 1.8
#2209637: Panopoly Theme breaks Panels add content with Jquery 1.8.

Sure :-)

Just did some testing with this again, and found some issues with our custom jQuery UI theme: the close button on the modal dialog was being displayed wrong. Here's a patch to panopoly_core to fix that!

EDIT: Trying latest patches on Travis-CI: https://travis-ci.org/panopoly/panopoly/builds/63350986

#2445119: Update Media to 2.0-alpha4 got committed, so this is unpostponed!

This failed automated testing, but I think it's actually because it's missing the Media update. You can see it's trying to create a Video widget but something is in it's way from clicking, which is an exact description of that bug. :-) I'm going to try kicking off another build and see if this one works:

https://travis-ci.org/panopoly/panopoly/builds/63376062

Huzzah! The tests passed. I think we're functionally good, but doing some more manual testing, I've been finding more visual regressions:

1. The jQuery UI theme in panopoly_core was breaking the dialog overlay, so I removed that code. Overall, we should probably audit that theme and see if we can update it to jQuery UI 1.10
2. The fix from #2458747: Media browser tabs give little indication that a tab is selected is no longer working, and needs some adjustment, so I've attached a patch for panopoly_widgets as well.

I've updated the issue summary with some TODO for finally getting this merged!

@RobLoach:

Query Update 3.0-alpha1 is also out, which allow updating to jQuery 2.1.4 with jQuery Migrate. Tried testing it, but am getting the following during installation:

Awesome! Glad to hear that development on jquery_update is moving forward so well. :-) However, since we're so close to getting jquery_update 2.5 working, let's try and get that merged ASAP and make a new issue for updating to jquery_update 3.x:

#2492801: Update jquery_update to version 3.x

Working on this has made me realize that jquery_update is really a core dependency, so I made an issue about moving it to panopoly_core:

#2492811: Move jquery_update to panopoly_core.make and .info

And thinking about the panopoly_widgets patch:

+++ b/panopoly-widgets-media-browser.css
@@ -10,14 +10,14 @@
-#media-tabs-wrapper .ui-tabs-nav li.ui-tabs-selected {
+#media-tabs-wrapper .ui-tabs-nav li.ui-tabs-active {

Actually, looking at jQuery UI 1.8, we should be able to use li.ui-state-active and have CSS that works for both 1.8 and 1.10! That would be the better way to go...

Put this on the sprint board!

@RobLoach: Thanks for the new panopoly_widgets patch! :-)

The patch on #22 needs to be merged with the panopoly_core patch on #15. And also all the stuff in the TODO in the issue summary!

Don't worry, this is still a priority! I'm hoping to get back to it soon. :-)

Could we target with projects[jquery_update][version] = 2 to ensure jQuery Update is always the latest 2.x?

No, sorry, we need the builds to be deterministic. If someone downloads an old version of Panopoly and rebuilds it, it needs to build it the same as it would have the day it was released. Or if another distro is including our features, they wouldn't expect a rebuild to produce a different result without changing anything in their .make files.

Also, if the update breaks things, we need a chance to fix those things before the update happens! If we had automatically jumped from 2.3 to 2.5, we'd have broken a number of things.

Anyway, after we finish this and upgrade to 2.5, if jquery_update 2.6 works without causing any of our automated tests to fail, the update to it will be a shoe in, just like most module updates. :-)

I've been attempting to do the first TODO item:

1. Audit the jQuery UI theme in panopoly_core and converting it from jQuery UI 1.8 to 1.10

And it's turning out to be quite tricky!

While what we have currently in this patch appears to work, what I'd really prefer to do is use theme roller to update the theme from 1.8 to 1.10 so that nothing is missing and we won't find some strange problems down the line. But it appears that it was modified by hand after getting it from theme roller, so can't just visit the link and re-generate for 1.10. And, unfortunately, I couldn't find the changes represented as commits in Git, so it's hard to see exactly what those changes are. :-/ Also, theme roller will no longer generate CSS for 1.8 so I can't ask it to make the same theme again to compare.

So, what I ended up doing was attempting to recreate something similar to the CSS before theme roller did it's thing by just concatenating the CSS files and a quick regex to pull out the markers for theme roller. Then I ran that and the Panopoly jQuery UI theme through a CSS beautifier and diffed them.

I'm going to quick upload those files here so that I don't lose them. But the next step is to use theme roller to generate a new theme for jQuery UI 1.10, and then look through the old diff and make sure everything is represented in the new theme.

Alright! Here is my first pass at a new set of patches which uses a panopoly-jquery-ui-theme.css which was completely rebuilt by ThemeRoller.

For future reference (ie. when I have to do this again) I've also attached the original CSS file from Theme Roller and a diff from that to what is actually included in this patch.

Also, I moved some media browser specific CSS out of the jQuery UI theme and into panopoly_widgets, where it really belongs. Now the jQuery UI theme is just a jQuery UI theme.

Updating the TODO in the issue summary.

Also, here's the Travis build of my last set of patches:

https://travis-ci.org/panopoly/panopoly/builds/66939788

Just took a stab at #3 on the TODO:

3. Audit the panopoly-widgets.css for any jQuery UI selectors.

So, while I didn't notice any issues with the Spotlight in my manual testing, it appears that the CSS for it in panopoly-widgets.css was using the obsolete .ui-tabs-selected class rather than .ui-state-active. So, here's an updated panopoly_widgets patch! I didn't notice any changes with it, but I think it's still worth doing.

EDIT: Here's a Travis build which includes this patch: https://travis-ci.org/panopoly/panopoly/builds/66942139

On the final TODO item:

4. More manual testing, especially of all uses of jQuery UI to make sure there are no functional or visual regressions!

I tried:

• The Media Browser (via the Video widget)
• The Linkit popup
• Manualcrop (not actually sure if this uses jQuery UI or not, but we don't have automated tests for it)

... and I didn't have any problems! However, I'd love for some other folks to do some more testing before I cross this one off the list and commit.

Tests pass! I'd really appreciate if at least one person other than me could do some manual testing - that would make me feel a lot more confident in committing this. :-)

I decided to go for it. :-) But it'd still be great if someone could try the -dev build and do a quick sanity check!