Even if #715146: Convert common syndication parser library to a class is abandoned basically, we can improve slightly the pluggability of the Common Syndication parser.

CommentFileSizeAuthor
#6 feeds_common_syndication_parser_alter-2492267-6.patch3.31 KBhmdnawaz
#5 feeds_common_syndication_parser_alter-2492267-5.patch3.37 KBhmdnawaz
#3 feeds_common_syndication_parser_alter-2492267-3.patch3.32 KBhmdnawaz
#2 interdiff-2492267-1-2.txt2.59 KBsardara
#2 2492267_feeds_common_syndication_parser_alter-2.patch3.22 KBsardara
#1 2492267_feeds_common_syndication_parser_alter-1.patch2.22 KBAron Novak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Aron Novak’s picture

Aron Novak
Primary language Hungarian
Location Hungary, Budapest
CreditAttribution: Aron Novak at Agence Inovae commented
FileSize
2492267_feeds_common_syndication_parser_alter-1.patch2.22 KB
sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital commented
FileSize
2492267_feeds_common_syndication_parser_alter-2.patch3.22 KB
interdiff-2492267-1-2.txt2.59 KB

With the patch provided in #1 I get a type hint error because _parser_common_syndication_RSS20_parse() is passing the $news variable which has been casted to array at that point. I'm providing a new patch to handle that.

hmdnawaz’s picture

hmdnawaz CreditAttribution: hmdnawaz commented
FileSize
feeds_common_syndication_parser_alter-2492267-3.patch3.32 KB

Updated the patch for the latest 7.x-2.x version.

Status: Needs review » Needs work

The last submitted patch, 3: feeds_common_syndication_parser_alter-2492267-3.patch, failed testing. View results

hmdnawaz’s picture

hmdnawaz CreditAttribution: hmdnawaz commented
Status: Needs work » Needs review
FileSize
feeds_common_syndication_parser_alter-2492267-5.patch3.37 KB
hmdnawaz’s picture

hmdnawaz CreditAttribution: hmdnawaz commented
FileSize
feeds_common_syndication_parser_alter-2492267-6.patch3.31 KB

Patch for version 7.x-2.0-beta4

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Category: Task » Feature request

@hmdnawaz
Would you like to add automated tests for this feature as well? The tests would need to cover that an item is alterable through the hook hook_common_syndication_parser_item_alter() and that the hook gets invoked for each feed type (rss, atom, rdf).

To cover this:

  1. Add a test module that implements the hook.
  2. For each feed type, add a test method to FeedsSyndicationParserTestCase.
  3. Enable the test module in each added test method.
  4. Tests if the alterations done in the hook implementation are kept after parsing (or after import).

In feeds/tests/feeds there are files for each feed type to parse.