Currently the "Empty option" on select compontents isn't translatable.
I included a patch to fix this issue.

CommentFileSizeAuthor
#6 2491945-make-empty-option-translatable.patch478 bytesJeroen_005
make-empty-option-translatable.patch544 bytesJeroen_005

Comments

Status: Needs review » Needs work

The last submitted patch, make-empty-option-translatable.patch, failed testing.

Jeroen_005’s picture

Jeroen_005 commented
Title: Select components (list, single-select, no default) to translate empty list option » Select components (list, single-select, no default) translate empty list option
Status: Needs work » Needs review
danchadwick’s picture

danchadwick commented
Version: 7.x-4.8 » 7.x-4.x-dev

DanChadwick queued make-empty-option-translatable.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, make-empty-option-translatable.patch, failed testing.

Jeroen_005’s picture

Jeroen_005 commented
StatusFileSize
new 2491945-make-empty-option-translatable.patch478 bytes

Created a new patch based on 7.x-4.x-dev

danchadwick’s picture

danchadwick commented
Status: Needs work » Needs review

@Jeroen_005 -- Have you thoroughly tested this with webform_localization? The testbot errors were unrelated to this patch. I'm not sure why the tests suddenly can't create users.

novitsh’s picture

novitsh commented

Set to Needs review for the dev version.

EDIT: The previous patch in #1 was matching against 7.x-4.8 only. That's why your retesting isn't working.

Jeroen_005’s picture

Jeroen_005 commented

@DanChadwick
Yeps both patches (#1 and #6) are tested with webform_localization 7.x-4.x-dev

Jeroen_005’s picture

Jeroen_005 commented

  • DanChadwick committed ad88042 on 7.x-4.x 
    Issue #2491945 by Jeroen_005: Select components (list, single-select, no...
danchadwick’s picture

danchadwick commented
Status: Needs review » Fixed

Committed to 7.x-4.x and 8.x. Thanks much!

  • DanChadwick committed 46fdec0 on 8.x-4.x 
    Issue #2491945 by Jeroen_005: Select components (list, single-select, no...
novitsh’s picture

novitsh commented

Could it be that on the commit you didn't mention the author?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.