When you add the comment form to a node, the node_comment_form.inc adds a form alterer to the comment form, however, because of it being in this include file, is not properly called except if the cache is being rebuilt.

Even more, this is on node_comment_form.inc but not on node_comment_wrapper.inc.

My proposed solution is to move those alterers into the .module file.

I played around with some include combinations but it seems that form alterers need to be on the module file.

CommentFileSizeAuthor
#1 2491479-1-comment-form-alter-hooks-in-module.patch2.02 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
StatusFileSize
new 2491479-1-comment-form-alter-hooks-in-module.patch2.02 KB
hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Needs review
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +panopoly

This patch makes sense to me! There was some change in one of the last releases of CTools that caused plugins to be loaded in fewer situations, so it seems reasonable that this was affected as well. FAPI really has no way to know that it needs to load that CTools plugin so this code needs to be in the .module.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2423731: Plan for CTools 7.x-1.8 release
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

ahh yah thats a simple little bug. Fixed.

  • japerry committed 2c7e636 on 7.x-1.x authored by hanoii 
    Issue #2491479 by hanoii: Comment form alterer is only called once on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.