Sort payment methods

Дуже дякую!

I am running into an issue that I believe is related to this patch, so I wanted to bump this up to get some attention.

I've installed Payment 7.x-1.15 on a fresh Drupal 7.38 install to test for a possible client event registration/payment system, and am receiving this warning message when I view admin/content/payment:

Warning: natcasesort() expects parameter 1 to be array, null given in payment_method_options() (line 1157 of ~/git/drupal-empty-testing/docroot/sites/all/modules/payment/payment.ui.inc).

Checking the code, it seems that line 1157 in the function payment_method_options() is using $pmid_options as a parameter, but that variable is completely uninitialized within the scope of the function. I suspect it is intended to be $options (or $options needs to be renamed to $pmid_options). I've pasted the current code below so you can see at a glance what I am referring to:

/**
 * Return payment methods for use in form elements.
 *
 * @return array
 *   Keys are payment method IDs. Values are payment method specific titles.
 */
function payment_method_options() {
  $options = array();
  foreach (entity_load('payment_method') as $payment_method) {
    $options[$payment_method->pmid] = check_plain($payment_method->title_specific);
  }
  natcasesort($pmid_options);

  return $options;
}

(This is my first post on the Drupal site, so please forgive any formatting errors... thank you!)

I just ran the patch on my local machine and the warning has disappeared. The change looks correct to me. Thanks for fixing it! Looking forward to the next release.

@amandahart: Welcome here, and thanks for reporting the problem and proposing the solution. I have credited you in the commit for your work. If you'd like to write patches yourself in the future, I can recommend these excellent handbook pages.

@a.milkovsky: thanks for the review, and giving credit!

Patch worked perfectly here as well!