When creating a CSV parser plugin to override the default FeedsCSVParse, the feeds_tamper checks for the class name (hardcoing the class "FeedsCSVParser") instead of checking if the parser is of instance of FeedsCSVParser. Getting the class name wrong creates a wrong value for the $is_csv variable. Using "instanceof" instead of get_class() can avoid this issue.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ranroz’s picture

twistor’s picture

Status: Active » Needs review

  • twistor committed 056daa4 on 7.x-1.x authored by ranroz
    Issue #2490120 by ranroz: Check for parser instance instead of class...
twistor’s picture

Status: Needs review » Fixed

Good call! Old code :(

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.