Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 May 2015 at 18:12 UTC
Updated:
2 Jun 2015 at 15:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
opdaviesComment #2
opdaviesForgot to update the issue status.
Comment #4
mikeburrelljr commentedApplied the above patch, and then corrected the following issues:
Comment #5
larowlanLooking good, the only thing I can fault here is that some of the comments are now > 80 chars which violates coding standards. However some of them were already.
> 80 chars
> 80 chars
Comment #6
mikeburrelljr commentedApplying recommended changes per @larowlan. (Including both a re-rolled patch file and an interdiff.)
Comment #7
larowlanLooks good to me - thanks!
Comment #8
xjmThat was fun. Reviewed locally with
git diff --color-words.This issue only changes documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x (with reviewer credit). Thanks!
Comment #10
xjmForgot to mention, there are still lots of
https://drupal.org(without the www) and a fewhttp://www.drupal.org(with the www, but with HTTP instead of HTTPS). I'd prefer to fix these in a followup since this patch was already 100K and is still all correct changes. Can someone open a followup for that and make a note to grep for these as a part of creating and reviewing the followup patch?Thanks!
Comment #11
opdaviesI'll do that. The original link that I noticed was on the installer page, which is still is the old URL - agreed that this should be done as a follow-up.
Comment #12
mikeburrelljr commented@opdavies I'll get this started now, and throw up a patch on where I leave off within the next hour... (New issue created at: https://www.drupal.org/node/2491155)
Comment #13
opdaviesGreat, thanks.
Comment #14
mac_weber commented