Problem/Motivation

All URLs in core modules still point to the old http://drupal.org URL. This now should be https://www.drupal.org.

Proposed resolution

Find and replace all instances of the old URL and replace it with the new URL.

Remaining tasks

User interface changes

API changes

Comments

opdavies’s picture

StatusFileSize
new92.2 KB
opdavies’s picture

Status: Active » Needs review

Forgot to update the issue status.

Status: Needs review » Needs work

The last submitted patch, 1: 2489912-1.patch, failed testing.

mikeburrelljr’s picture

Status: Needs work » Needs review
StatusFileSize
new92.45 KB

Applied the above patch, and then corrected the following issues:

  • Updated url for http://drupal.org/planet/rss to http://drupal.org/planet/rss.xml in file core/modules/aggregator/src/Tests/FeedValidationTest.php
  • Updated the serialized content length to reflect the correct number of characters for the longer domain in file core/modules/migrate_drupal/src/Tests/Table/d6/ContentNodeFieldInstance.php (from 17 to 22)
  • Updated the test for Drupal\views\Tests\Handler\FieldWebTest->testAlterUrl() so that it doesn't look for https:// (and added www) so that the test passes
larowlan’s picture

Looking good, the only thing I can fault here is that some of the comments are now > 80 chars which violates coding standards. However some of them were already.

  1. +++ b/core/modules/locale/locale.module
    @@ -199,7 +199,7 @@ function locale_theme() {
    +  // @todo move these two cache clears out. See https://www.drupal.org/node/1293252
    
    @@ -210,7 +210,7 @@ function locale_configurable_language_insert(ConfigurableLanguageInterface $lang
    +  // @todo move these two cache clears out. See https://www.drupal.org/node/1293252
    
    +++ b/core/modules/locale/locale.translation.inc
    @@ -58,7 +58,7 @@ function locale_translation_get_projects(array $project_names = array()) {
    +    // https://www.drupal.org/node/1777106 is a follow-up issue to make the check for
    
    +++ b/core/modules/locale/src/Form/TranslationStatusForm.php
    @@ -193,7 +193,7 @@ protected function prepareUpdateData(array $status) {
    +    //   get a module name. In follow-up issue https://www.drupal.org/node/1842362
    
    +++ b/core/modules/taxonomy/src/Form/OverviewTerms.php
    @@ -80,7 +80,7 @@ public function getFormId() {
    +    // @todo Remove global variables when https://www.drupal.org/node/2044435 is in.
    
    +++ b/core/modules/taxonomy/src/Plugin/views/filter/TaxonomyIndexTid.php
    @@ -191,7 +191,7 @@ protected function valueForm(&$form, FormStateInterface $form_state) {
    +          // @todo Sorting on vocabulary properties https://www.drupal.org/node/1821274
    
    +++ b/core/modules/update/src/UpdateProcessor.php
    @@ -165,7 +165,7 @@ public function processFetchTask($project) {
    +      // @todo: Purge release data we don't need (https://www.drupal.org/node/238950).
    
    +++ b/core/modules/views/src/Plugin/views/join/Subquery.php
    @@ -56,7 +56,7 @@ public function buildJoin($select_query, $table, $view_query) {
    +    // This is just copied verbatim from the parent class, which itself has a bug: https://www.drupal.org/node/1118100
    
    +++ b/core/modules/views/src/Plugin/views/query/Sql.php
    @@ -748,7 +748,7 @@ public function addField($table, $field, $alias = '', $params = array()) {
    +    // PostgreSQL truncates aliases to 63 characters: https://www.drupal.org/node/571548
    
    +++ b/core/modules/views/src/Tests/Plugin/PagerTest.php
    @@ -41,12 +41,12 @@ class PagerTest extends PluginTestBase {
    +    // Test behavior described in https://www.drupal.org/node/652712#comment-2354918.
    
    @@ -68,7 +68,7 @@ public function testStorePagerSettings() {
    +    // Test behavior described in https://www.drupal.org/node/652712#comment-2354400
    

    > 80 chars

  2. +++ b/core/modules/system/database.api.php
    @@ -466,7 +466,7 @@ function hook_query_TAG_alter(Drupal\Core\Database\Query\AlterableInterface $que
    + * See the Schema API Handbook at https://www.drupal.org/node/146843 for details on
    

    > 80 chars

mikeburrelljr’s picture

Applying recommended changes per @larowlan. (Including both a re-rolled patch file and an interdiff.)

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me - thanks!

xjm’s picture

Component: other » documentation
Status: Reviewed & tested by the community » Fixed

That was fun. Reviewed locally with git diff --color-words.

This issue only changes documentation, so per https://www.drupal.org/core/beta-changes, this can be completed any time during the Drupal 8 beta phase. Committed and pushed to 8.0.x (with reviewer credit). Thanks!

  • xjm committed f9b6f97 on 8.0.x
    Issue #2489912 by mikeburrelljr, opdavies, larowlan: Update Drupal.org...
xjm’s picture

Issue tags: +Needs followup

Forgot to mention, there are still lots of https://drupal.org (without the www) and a few http://www.drupal.org (with the www, but with HTTP instead of HTTPS). I'd prefer to fix these in a followup since this patch was already 100K and is still all correct changes. Can someone open a followup for that and make a note to grep for these as a part of creating and reviewing the followup patch?

grep -r "//drupal.org" *
grep -r "http://www.drupal.org" *

Thanks!

opdavies’s picture

Can someone open a followup for that and make a note to grep for these as a part of creating and reviewing the followup patch?

I'll do that. The original link that I noticed was on the installer page, which is still is the old URL - agreed that this should be done as a follow-up.

mikeburrelljr’s picture

@opdavies I'll get this started now, and throw up a patch on where I leave off within the next hour... (New issue created at: https://www.drupal.org/node/2491155)

opdavies’s picture

New issue created at: https://www.drupal.org/node/2491155

Great, thanks.

mac_weber’s picture

Issue tags: -Needs followup

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.