See #2188165: [Regression] View term filter 'is/not empty' and 'not one of' operators do not work for more. Since the core views taxonomy term filter handler had this bug, when it was forked into a SearchAPI views handler, the same bug remains. Although we need to fix this "upstream" in various places, we actually need to fix the copy in SearchAPI to fix the behavior on d.o itself. I'm working on a patch now, stay tuned.

CommentFileSizeAuthor
#1 2489882-1.search-api-taxonomy-handle-empty.patch1.66 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 2489882-1.search-api-taxonomy-handle-empty.patch1.66 KB

See #2188165-9: [Regression] View term filter 'is/not empty' and 'not one of' operators do not work for the specifics of why this patch is both ugly and correct. ;)

dww’s picture

dww
we/he/they
commented
Issue tags: +needs drupal.org deployment

I deployed this on https://lax1-drupal.redesign.devdrupal.org and confirmed that it fixes the problems. I haven't done an exhaustive test of everything SearchAPI-related, but quick poking around looks reasonable.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

This is really not ideal, but without refactoring how $this->operator is populated all across views, we're stuck with this in D7.
I committed the Views equivalent of this.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot for the report, the patch and the review!
I haven't reviewed or tested it exhaustively, but it looks reasonable enough, and if you two say it works, then I'll take your word.
So, committed. Thanks again!

Oh, and for the future: for issues affecting d.o you are welcome to ping me via mail/contact form!

  • drunken monkey committed 8dc293b on 7.x-1.x authored by dww 
    Issue #2489882 by dww: Fixed Views taxonomy filter with "is (not) empty...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: -needs drupal.org deployment

Finally deployed to Drupal.org.