move image.theme.css to classy

moving images css to classy :)

core/modules/image/src/Plugin/Field/FieldWidget/ImageWidget.php:
  163  
  164      $element['#theme'] = 'image_widget';
  165:     $element['#attached']['library'][] = 'image/form';
  166  
  167      // Add the image preview.

We need to remove this attachment here.

removed code as per suggestion in #4

Nice, thanks. It looks like the test shouldn't be too hard to fix. We need to take screenshots before/after in Classy and Seven.

Update patch #6 I think that we need attach library to /core/themes/classy/templates/content-edit/image-widget.html.twig

Manually testing (or committing) this may be blocked on #2511036: image-widget.html.twig never gets used (image_widget gets overridden by FieldWidget::process).

Rerolled.

No visual changes so won't be uploading screenshots

Why is the library called drupal.image?

Actually to get this align with other issues we probably should remove that library

@lauriii This was originally a separate library in the module, so I think it should stay a separate library in Classy?

Oh yeah and its being loaded conditionally. We still should rename the drupal.image to only image.

I renamed this library and the file to image-widget to better describe the contents.

Should this go in a css/theme folder, since it is being added to the theme category?

+++ b/core/themes/classy/classy.libraries.yml
@@ -27,3 +27,9 @@ search.results:
+    theme:
+      css/components/image-widget.css: {}

Nope this is a component so we should switch to component.

looks like you only need the 1 line change, I'll add that to your patch.

just re-rolled with the small change. Couldn't find the right place to test it properly. Isn't this template supposed to load on any image field edit?

doh! double uploaded.

OK, I made a mess out of the last upload, so I am going to just upload it again.

just re-rolled with the small change. Couldn't find the right place to test it properly. Isn't this template supposed to load on any image field edit?

(2nd attempt at upload, repeating #29)

It looks like this can't be tested until #2511036: image-widget.html.twig never gets used (image_widget gets overridden by FieldWidget::process) is committed so setting to postponed for now.

Now we can test this patch

Reroll.

It loads! Setting to RTBC/postponed.

Did you mean to change the status?

Yes :P Thanks