Problem/Motivation

Lets reduce the reliance on text that starts with "If, When" this is bad practice according to our UI standards.

Proposed resolution

Remaining tasks

Before

After

User interface changes

API changes

CommentFileSizeAuthor
#11 after-apply-patch.png63.05 KBmanjit.singh
#11 before-apply-patch.png67.04 KBmanjit.singh
#8 exposedoptionreduction-8.patch3.32 KByogen.prasad
#4 Views_Exposed_option.png27.78 KBmanauwarsheikh
#4 core-exposedoptions-enhancement-4.patch3.64 MBmanauwarsheikh
#3 views_exposed.png26.41 KBmanauwarsheikh
#2 Exposed Options After - Unchecked.png42.11 KBnateb
exposedoptionreduction.patch3.23 KBBojhan
Screen Shot 2015-05-15 at 10.41.16.png104.03 KBBojhan
Screen Shot 2015-05-15 at 10.22.25.png85.12 KBBojhan

Comments

Bojhan’s picture

Bojhan commented
Issue summary: View changes
nateb’s picture

nateb commented
Issue summary: View changes
Issue tags: +UX, +ui, +DrupalCon LA
StatusFileSize
new Exposed Options After - Unchecked.png42.11 KB

Evaluating as part of DrupalCon LA Friday sprint.

I agree that this can be improved!

It's somewhat obvious for those experienced with Drupal Views, but maybe worth mentioning for others who come along that this is found in a View, e.g. Frontpage (found at /admin/structure/views/view/frontpage) under Pager options (assuming pagination is enabled).

BTW this is the Exposed Options checkbox array after applying this patch in its default state:

I think a few wording changes could improve this more:

- "Allow users to control options of the shown view."
+ "Allow user to control selected display options for this view."

- "Control the number of items in a view"
+ "Allow user to control the number of items displayed in this view"

- "Option to show all items"
+ "Allow user to to display all items"

- "Control the offset in a view"
+ "Allow user to control offset in this view" OR
+ "Allow user to specify number of items skipped from beginning of this view." – if defining what "offset" means could benefit the admin.

Whaddya think?

manauwarsheikh’s picture

manauwarsheikh commented
Assigned: Unassigned » manauwarsheikh
Status: Needs review » Needs work
Issue tags: +#SrijanSprintDay
StatusFileSize
new views_exposed.png26.41 KB

Reviewed.
The Initial set of requirements is fine.I will commit patch for latest requirements.
attached screenshot

manauwarsheikh’s picture

manauwarsheikh commented
Assigned: manauwarsheikh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new core-exposedoptions-enhancement-4.patch3.64 MB
new Views_Exposed_option.png27.78 KB

I have changed the views exposed option,as suggested in last comment.

Status: Needs review » Needs work

The last submitted patch, 4: core-exposedoptions-enhancement-4.patch, failed testing.

RavindraSingh queued exposedoptionreduction.patch for re-testing.

yogen.prasad’s picture

yogen.prasad commented
Assigned: Unassigned » yogen.prasad
yogen.prasad’s picture

yogen.prasad commented
StatusFileSize
new exposedoptionreduction-8.patch3.32 KB

Created patch with changes mentioned in #2

yogen.prasad’s picture

yogen.prasad commented
Status: Needs work » Needs review
yogen.prasad’s picture

yogen.prasad commented
Assigned: yogen.prasad » Unassigned
manjit.singh’s picture

manjit.singh
Primary language Hindi
Location Chandigarh
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +SrijanSprintNight
StatusFileSize
new before-apply-patch.png67.04 KB
new after-apply-patch.png63.05 KB

Thanks Yogendra for worked on this, Changes looks good to me.

RTBC+ :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5680ad0 and pushed to 8.0.x. Thanks!

UI test is not yet frozen in beta.

  • alexpott committed 5680ad0 on 8.0.x 
    Issue #2489400 by Bojhan, manauwarsheikh, yogen.prasad, Manjit.Singh,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.