We have a random fail introduced by #2450897: Cache Field views row output Drupal\views\Tests\Plugin\RowRenderCacheTest (219 pass(es), 56 fail(s), and 0 exception(s))

CommentFileSizeAuthor
#1 2489100.1.patch655 bytesalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2489100.1.patch655 bytes

We have an ordering issue with the nodes created.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Looks like a perfect fix!

fabianx’s picture

fabianx commented

RTBC + 1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I've ran the test over 200 times with the patch and had no fails.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2489100.1.patch, failed testing.

Status: Needs work » Needs review

alexpott queued 1: 2489100.1.patch for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

The fail in the patch was a SimpleXMLImport failure and unrelated.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 959a0df on 8.0.x 
    Issue #2489100 by alexpott: Random fail in Drupal\views\Tests\Plugin\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.