Upgrade egulias/EmailValidator to 1.2.9

Thanks for working on this issue! There is no need to change the version in composer.json. I will explain why. By itself, editing composer.json has no effect on Drupal because Drupal ships the vendor directory. In other words, the person installing Drupal 8 does not run composer install—composer install must be run by us. Drupal 8 is different than other projects in this regard.

And in this case, I think we are happy with the 1.2.* release series so we can leave that alone.

Run a composer update on this library and include the patch of that.

It looks like you must update doctrine/lexer at the same time. You can pass it as another argument.

composer.lock should be in the patch. I get a different patch when I run composer update egulias/email-validator doctrine/lexer. For example, you have changes to ClassLoader that I don't have. What command did you run?

@joshi.rohit100 You have changes to this file that I do not have when I execute the same command:
core/vendor/composer/ClassLoader.php.

Could you run composer selfupdate then composer update egulias/email-validator doctrine/lexer to see what you get?

@joshi.rohit100 Also, be sure to git pull in your Drupal 8.0.x working copy.

1.2.7 is the highest we can go because 1.2.9 requires doctrine/lexer >=1.0.1 and core has doctrine/lexer 1.0.

We are not upgrading doctrine/lexer to v1.0.1 with #21. I don't understand how this works in this case - you can see that core/composer.lock leaves doctrine/lexer at v1.0 with this patch, yet core/vendor/egulias/email-validator/composer.lock says 1.0.1. Perhaps egulias/email-validator was nominally developed against 1.0.1 but it does not require it. We are probably ok:

core/vendor/egulias/email-validator/composer.json:

  //...
  "require":      {
    "php": ">= 5.3.3",
    "doctrine/lexer": "~1.0"
  },
  //...

We are not upgrading doctrine/lexer to v1.0.1 with #21. I don't understand how this works in this case - you can see that core/composer.lock leaves doctrine/lexer at v1.0 with this patch, yet core/vendor/egulias/email-validator/composer.lock says 1.0.1. Perhaps egulias/email-validator was nominally developed against 1.0.1 but it does not require it. We are probably ok:

core/vendor/egulias/email-validator/composer.json:

  //...
  "require":      {
    "php": ">= 5.3.3",
    "doctrine/lexer": "~1.0"
  },
  //...

@naveenvalecha Open an issue to upgrade doctrine/lexer, if one does not already exist, and post the link to the issue here.

Agreed we will go to 1.2.9 after #2516078: Upgrade doctrine/lexer to v1.0.1.

Aggravatingly, the current version of egulias/email-validator in HEAD prevents going higher that ~1.0 on doctrine/lexer.

@catch Well the plot thickens - 1.0.1 is the highest lexer version, so we can get #2516078: Upgrade doctrine/lexer to v1.0.1 in then just do this.

This is unblocked now.

Too - late, maybe post a review.

#37 is missing file rename. This is the one we want.

The .gitignore file did not change in the composer update. I am not sure what you mean.

This is ready to go if it is green.

A reroll.