Problem/Motivation

FlagCountManagerInterface::getTotals() has a $reset parameter for clearing the static cache. However, this is no longer needed, since as of D7 (!!) functions should use drupal_static() to allow their cache to be cleared.

Proposed resolution

Remove the parameter, and the code that clears the cache when the parameter is set to TRUE.

Remaining tasks

- create a patch
- update the CR at https://www.drupal.org/node/2476349

CommentFileSizeAuthor
#1 flag-remove_reset_gettotals-2488288-1.patch1.41 KBgnuget

Comments

gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new flag-remove_reset_gettotals-2488288-1.patch1.41 KB

Patch attached.

joachim’s picture

joachim commented
Status: Active » Needs review

Thanks for the patch!

Let's see what the testbot says...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Uhm ;)

#1577902: [META] Remove all usages of drupal_static() & drupal_static_reset()

drupal_static() shouldn't be used in services. Which means that some way to reset it is often necessary, but usually in the form of a separate method. It's also usually only necessary for tests.

joachim’s picture

joachim commented

Thanks for the info!

We can still fix this issue as is though, and then move on to changing drupal_static() calls in new one.

joachim’s picture

joachim commented

Filed #2488458: remove calls to drupal_static().

joachim’s picture

joachim commented
Status: Needs review » Fixed

Tests pass, patch looks good.

Committed, and I'm about to update the CR. EDIT: which doesn't mention the $reset at all, so it's ok already.

Thanks!

  • joachim committed 2b32e27 on 8.x-4.x authored by gnuget 
    Issue #2488288 by gnuget: Removed obsolete $reset parameter from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.