Since #2288747: Panels Title Headings and #2288741: Title Headings was committed, I haven't been able to override the default pane title heading tag from say an h2 to an h3.

Here is a small patch that works for me.

Hope that helps

CommentFileSizeAuthor
#3 2488280-ctools-cant-override-default-pane-title-headings-tag.patch741 bytesgmclelland
#1 2488280-cant-override-default-pane-title-heading-tag.patch716 bytesgmclelland

Comments

gmclelland’s picture

gmclelland commented
Status: Active » Needs review
StatusFileSize
new 2488280-cant-override-default-pane-title-heading-tag.patch716 bytes

and here is the patch

gmclelland’s picture

gmclelland commented

I'm not sure if changes need to made as well to the code in ctools? #2288741: Title Headings

The patch I posted here allows me to set $conf['override_title_heading'] = 'h3'; in my settings.php to override the default heading tag. I also tested the overriding a single pane to a different header tag and it worked.

gmclelland’s picture

gmclelland commented
StatusFileSize
new 2488280-ctools-cant-override-default-pane-title-headings-tag.patch741 bytes

@japerry - As discussed in IRC, here is the needed patch for Ctools as well.

Status: Needs review » Needs work

The last submitted patch, 3: 2488280-ctools-cant-override-default-pane-title-headings-tag.patch, failed testing.

ifrik’s picture

ifrik
she/her
commented

I've got the same problem. Happy to review any working patch.

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
commented

If this requires a patch for ctools, you should post it in that module's issue queue and link it here as a related issue.

adrien.felipe’s picture

adrien.felipe commented

I was going to post the exact same patch. Glad someone else needed the same.
I wonder in what situation ctools needs the patch?
Also, if someone points me to the documentation where this should be documented, I'll update it.

mvc’s picture

mvc
they
Primary language English
Location Montréal, CA
commented
Status: Needs work » Reviewed & tested by the community

forgot to update: we're using this patch & it works for us.

  • japerry committed 7445dd8 on 7.x-3.x authored by gmclelland 
    Issue #2488280 by gmclelland: override the default Pane title heading...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

flow1990’s picture

flow1990 commented 
I override panels-pane.tpl.php, and add this :
<?php 
$heading_level = 'h2';
?>
...
      <?php if (isset($pane->configuration['override_title_heading'])
        && !empty($pane->configuration['override_title_heading'])):?>
        <?php $heading_level = $pane->configuration['override_title_heading']?>
    <?php endif; ?>
      <<?php print $heading_level; ?><?php print $title_attributes; ?>><?php print $title; ?></<?php print $heading_level; ?>>
...