Love the module concept and will definitely be keeping my eye on the proposed multisite sensor.

Came across this small nit in my travels:

Problem/Motivation

On the summary page of the demo, the following link leads to a 404:

Configure[1] the module by submitting the default settings.

[1] ###/monitoring-demo#overlay=admin/config/system/monitoring/sensors/enabled_modules

Proposed resolution

Change enabled_modules to monitoring_enabled_modules.

CommentFileSizeAuthor
#4 monitoring-page_not_found_demo-2487035-4_8x.patch1.52 KBothermachines
#1 monitoring-page_not_found_demo-2487035.patch1.46 KBothermachines

Comments

othermachines’s picture

othermachines commented
Status: Active » Needs review
StatusFileSize
new monitoring-page_not_found_demo-2487035.patch1.46 KB

Dead simple patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Thanks, committed, 8.x-1.x might need to be updated too.

  • Berdir committed 2509296 on 7.x-1.x authored by othermachines 
    Issue #2487035 by othermachines: Fixed Page Not Found in simplytest.me...
othermachines’s picture

othermachines commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new monitoring-page_not_found_demo-2487035-4_8x.patch1.52 KB

Patch for 8.x-1.x. Cheers -

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Thank you, fixed it!

BTW: Please add a comment in the multisite sensor issue about your thoughts.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.