Replace this -
// If the path is empty, generate the path from the <front> route. If
// the path does not start with a leading, then run it through
// Url::fromUri('base:')->toString() to get correct the base
// prepended.with
// If the path is empty, generate the path from the <front> route. If
// the path does not start with a leading slash, then run it through
// Url::fromUri('base:')->toString() to get the correct base
// prepended.| Comment | File | Size | Author |
|---|---|---|---|
| #21 | drupal-doc-fix-assert-breadcrumbs-2486911-21.patch | 933 bytes | mark.labrecque |
| #18 | drupal-doc-fix-assert-breadcrumbs-2486911-18.patch | 919 bytes | mark.labrecque |
| #13 | drupal-doc-fix-assert-breadcrumbs-2486911-13.patch | 929 bytes | mark.labrecque |
| #8 | drupal-2486911-test-code-documentation-8.patch | 364 bytes | mark.labrecque |
| #4 | 2486911-4.patch | 806 bytes | joshi.rohit100 |
Comments
Comment #1
kgoel commentedComment #2
kgoel commentedComment #3
jhodgdonLooks like a good novice issue to add that one word "slash" to the comment, if kgoel is not planning to do a patch!
Comment #4
joshi.rohit100Comment #5
mark.labrecqueThis looks pretty straight forward, so I'm going to mark this as RTBtC
Comment #6
jhodgdonActually... the rest of that comment doesn't make grammatical sense. Can we fix it so it does? I didn't notice but the issue summary actually has a correction for that part too. Thanks!
Comment #7
mark.labrecqueComment #8
mark.labrecqueI just created a new patch, since the previous was just a one-word change. @jhodgdon: let me know if this is all that was required.
Thanks!
Comment #9
mark.labrecqueComment #10
jhodgdonWrong patch there. :) I think you uploaded the patch I just committed on a different issue.
Comment #11
mark.labrecqueWell, that's embarressing! Here's the correct file :)
Comment #12
mark.labrecqueWait, no that is still incorrect. Please stand by ;)
Comment #13
mark.labrecque*hangs head in shame*
Here it is
Comment #14
mark.labrecqueComment #15
mark.labrecqueComment #16
mark.labrecqueComment #17
kgoel commentedThis is close. It's missing "the". It would be - to get the correct base prepended.
Comment #18
mark.labrecqueGood catch!
Normally, I would add a interdiff, but my terminal was griping at me, and it's a pretty simple change.
Thanks!
Comment #19
mark.labrecqueComment #21
mark.labrecqueI think there were some upstream changes that needed merging. Maybe this one?
Comment #22
mark.labrecqueComment #23
jhodgdonNo worries! Everyone uploads the wrong patch from time to time. ;)
Anyway, the latest patch looks good to me. Thanks!
Comment #24
jhodgdonRecharacterizing as a bug. Garbled comment is a (minor) bug. Allowed during beta as it is a docs-only bug fix, no disruption, etc.
Comment #25
benjifisherI am removing the Novice Tag from this Issue because all tasks have been completed.
Comment #26
mark.labrecqueHas this been committed yet, or is there something special that needs to happen to bugs in beta phase pre-commit?
Comment #27
jhodgdonPatience! It just hasn't been committed yet. People are at DrupalCon this week; this usually slows progress on getting things committed.
Comment #28
mark.labrecqueoh no worries at all :) I just wanted to make sure nothing more was needed in terms of clean-up or follow through. I am a new contributor, so still learning the ropes a bit
Thanks for all your help jhodgdon!
Comment #29
alexpottCommitted c7f34bd and pushed to 8.0.x. Thanks!