Hi,

we have a really confusing issue, reproducable in as now in a second test system ... if we update the webform module from 7.x-4.7 to 7.x-4.8 in our emails generated by transmitting the webforms some numbers will be replaced by strings:
Here is an example:

Timestamp in an email which was sent by rule -> Send HTML eMail:

before (7.x-4.7)
Fri, 2015-04-17 11:28 Timestamp The date the file was most recently changed.

after (7.x-4.8)
Fri, 2restrictfile5-restrict4-file7 filefile:28 Timestamp The date the file was most recently changed.

Means ... "0" is replaced with "restrict" and "1" is replaced with "file".

Timestamp in an email which was sent by rule -> Send eMail:

before (7.x-4.7)
Fri, 2015-04-17 11:28 Timestamp The date the file was most recently changed.

Timestamp in an email which was sent by rule -> Send eMail:
Fri, 20file5-04-file7 filefile:28 Timestamp The date the file was most recently changed.

Means ... "0" is not replaced, but "1" is replaced with "file".

Please notice that this really comes up after updating the webform module, without any other changes in the system - and naturally the webform emails are wrong too:

Example:

After update to 7.x-4.8
Upload information:

Description: test datedateentity
Submitted: structdateentitysubmission-datesubmission-entityentity entityuser:entity6
User: tdia
First name: Thomas
Last name: Xxxxxxxx
Company: XXXXXXX
Recipient entity: thomas.xxxxxxx@xxxxxx.com
Recipient struct: thomas.xxxxxxx@xxxxxx.com
Submission-IP: entity78.structuser.89.structstruct6
Submission-ID: entitydateuserdate
──────────────────────────────────────────────────────────────────
Uploaded file will be deleted after profile2date days.

Before Update webform
Upload information:

Description: Xxxxxxxxxxxxxxxxxxxx_xxxx_xxxx_EN
Submitted: 2015-05-11 14:45
User: xxxxx
First name: Martin
Last name: xxxxxx
Company: XXXXXX Software
Recipient 1: thomas.xxxxxx@xxxxxx.com
Recipient 2: thomas.xxxxxx@xxxxx.com
Submission-IP: 178.24.89.226
Submission-ID: 1079
──────────────────────────────────────────────────────────────────
Uploaded file will be deleted after 30 days.
Thanks.

We currently dont have any idea why this coming up.
Thomas

Comments

TDI007’s picture

Issue summary: View changes
danchadwick’s picture

Category: Bug report » Support request
Status: Active » Fixed

I'm 99.9% sure this isn't a bug in webform itself. For example, "restrict" does not appear in the source code anywhere.

I am wondering if you have some opcode cache problem. Is there anything in the error log?

I would look at the text filter you are using. Anything that might be related?

Try disabling all modules other than webform and its dependencies to see if you can narrow down a module compatibility interaction.

If you can figure this out by yourself, you'll have to hire a developer to work through the emails to see where they are being corrupted. I don't think there is anything more I can do since it's not my site.

Matroschker’s picture

I'm working on the same installation as TDI007, I did some tests...

- start, stop apache and mysql service, clear cache - nothing changed
- check apache logs, drupal recent logs - no error messages depending to this
- deactivate opcache in php.ini - nothing changed
- change used filter for emails, we had active a full html filter, I test filtered html or plain text - no significant changes in the email
...Mon, 2sitefile5-site5-filefile 22:filefile Current date The current date and time.
...Mon, 2sitefile5-site5-filefile 22:site7 Current date The current date and time.
...Mon, 2sitefile5-site5-filefile 22:file5 Current date The current date and time.
- change Mailsystem (Default, MimeMail) - nothing changed

But why this effect only occures if we update the webform module? I found some interesting in this post https://www.drupal.org/node/2139287#comment-9630397 - here one of our effects is described - submission id is not more available, because renaming is happening to early - maybe the problem we describe is a side effect?

danchadwick’s picture

4.8 uses system date formats. Check your global webform settings to see what format is selected, then check the core settings to see that it is. Maybe that's related?

match79’s picture

I am seeing the same problem with webforms after update: 0 is replaced with 'date' and 1 with 'submission' in the form emails.

Turns out that it is solved for me by disabling the 'webform clear' module, which is presumably not compatible with the latest version of webforms. It might be the Name collision issue listed here: https://www.drupal.org/project/issues/webform_clear?categories=All

TDI007: Is this a module you are using?

danchadwick’s picture

Title: After Update 7.x-4.7 to 7.x-4.8 confusing replacements in email component » Confusing replacements in email component caused by webform_clear module conflict
Category: Support request » Feature request
Related issues: +#2485951: Name collision between Webform Clear and webform function webform_clear_tokens()
StatusFileSize
new1.5 KB

Nice detective work, @match79!

It would be highly advisable for all webform-related modules to use webformxxxx rather than webform_xxxx for this very reason. I have renamed webform_clear_tokens to webform_replace_tokens_clear. If there's a module called webform_replace, I'm going to explode.

Committed to 7.x-4.x and 8.x

  • DanChadwick committed 93403dd on 8.x-4.x
    Issue #2486765: Avoid namespace conflict with webform_clear modules (...
Matroschker’s picture

Really, really great ... it's fantastic.
Yes we are using webform_clear in version 7.x-2.0.
I have implemented the patch and now it works.

Many thanks to all.
Matroschker

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.