Problem/Motivation

Exporting configurations is now supported and helps with performance when creating an array from the schema file. Since a recent change, ConfigEntityType annotation can declare an array of config entities to export, which saves a lot of time, for example during site install.

Proposed resolution

Apply the patch.

Remaining tasks

None

User interface changes

None

API changes

None

CommentFileSizeAuthor
#9 add_config_export_to-2485581-9.patch1.08 KBLKS90
#1 configExport_2485581_1.patch2.02 KBLKS90
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
Status: Active » Needs review
FileSize
configExport_2485581_1.patch2.02 KB

Here is the patch, test are passing, default config is okay :).

Status: Needs review » Needs work

The last submitted patch, 1: configExport_2485581_1.patch, failed testing.

Status: Needs work » Needs review

LKS90 queued 1: configExport_2485581_1.patch for re-testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Looks good I think.

This helps with install performance, if we can install everything of a module without having to rebuild the typed config definitions then we can save quite a bit of processing, especially when multiple modules are installed together.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot for your work!
Committed.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Fixed » Needs work

After reading through #2273631: Unify config entity schemas with a base schema type, it seems to me we should remove the keys in the config_entity schema (uuid, langcode, status, dependencies and third_party_settings) from our own schema definitions when changing their type to config_entity? Or is there a reason to keep them?

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented

I changed the type from mapping to config_entity in this issue (to get the tests to pass :D).

Berdir said they can be removed, only our own keys have to be listed. Will provide a patch later.

LKS90’s picture

LKS90 CreditAttribution: LKS90 at MD Systems GmbH commented
Title: Add config_export to Index and Server ConfigEntityType annotation » Fix config_export in Index and Server ConfigEntityType annotation
Status: Needs work » Needs review
FileSize
add_config_export_to-2485581-9.patch1.08 KB

Here is the patch that removes the unnecessary keys from the annotation.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Fixed

Thanks! Committed.

  • drunken monkey committed 1abb807 on 8.x-1.x authored by LKS90 
    Follow-up to #2485581 by LKS90: Fixed config_export in Index and Server...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.