Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Current version: 2.1.3
New version: 2.1.4
Comment | File | Size | Author |
---|---|---|---|
#16 | update-jquery-2485575-16.patch | 665.98 KB | willzyx |
#11 | update-jquery-2485575-11.patch | 414.99 KB | ram4nd |
#9 | update-jquery-2485575-9.patch | 415 KB | ram4nd |
#4 | update-jquery-2485575-4.patch | 415 KB | iMiksu |
Comments
Comment #1
nod_When updating include the minified file, the original source and the source map file.
Comment #2
Wim LeersComment #3
iMiksuComment #4
iMiksuComment #5
evilfurryone CreditAttribution: evilfurryone at Wunder commentedApplied #4, verified that jquery v2.1.4 is being used. Clicked around the site and encountered no issues.
Comment #6
Wim LeersPatch looks good; manually tested in #5.
Comment #7
willzyx CreditAttribution: willzyx commentedThis release does not contain the sourcemap comment in the minified file. I think we need to add the appropriate sourcemap comment at the end of the minified file
Comment #8
ram4nd CreditAttribution: ram4nd as a volunteer and at Wunder commentedComment #9
ram4nd CreditAttribution: ram4nd as a volunteer and at Wunder commentedJust added the "//# sourceMappingURL=jquery.min.map" to the js file.
Comment #10
ram4nd CreditAttribution: ram4nd as a volunteer and at Wunder commentedComment #11
ram4nd CreditAttribution: ram4nd as a volunteer and at Wunder commentedSomething went wrong with the previous patch, I re-rolled it.
Comment #12
evilfurryone CreditAttribution: evilfurryone at Wunder commentedCan confirm " //# sourceMappingURL=jquery.min.map " in end of the minified jquery file.
Comment #13
aspilicious CreditAttribution: aspilicious commentedDIdn't you forget to update the original source file?
Comment #14
ram4nd CreditAttribution: ram4nd as a volunteer and at Wunder commentedI am not sure that I understand what you are trying to say.
Comment #15
aspilicious CreditAttribution: aspilicious commentedI see an updated
- Minified file
- A source map
I don't see an updated original source file.
If it doesn't exist yet we have to add it.
Comment #16
willzyx CreditAttribution: willzyx commentedAdded source file
Comment #17
aspilicious CreditAttribution: aspilicious commented@nod_ should verify if everything is ok now.
Comment #18
nod_This is good to go. When debugging we see the actual unminfied source, all good.
The version bump for jQuery is related to a safari bug and the use of
$.each
with weird objects (2.1.3..2.1.4). Since we don't do any of that in core, we're not impacted.Comment #19
alexpottThe min.map file does not appear to match http://code.jquery.com/jquery-2.1.4.min.map - am I wrong? The uncompressed js is exactly the same as http://code.jquery.com/jquery-2.1.4.js and the minified file has the expected difference of the source map comment.
Comment #20
nod_The changes to the map file are required. This is the exact changes between what jquery ships and the patch:
Original:
"file":"jquery-2.1.4.min.js","sources":["jquery-2.1.4.js"]
Ours:
"file":"jquery.min.js","sources":["jquery.js"]
We either rename the jquery files or the map file. I'd rather rename the map file.
Comment #21
alexpott@nod_ yes we need to change our map file. We I mean is that the patch has a different map file from http://code.jquery.com/jquery-2.1.4.min.map - which surprises me.
Comment #22
nod_Umm not sure what's going on. We're working under the assumptions that we want to keep "jquery.min.js" as the filename for the script, which is why we need to rename all the files (removing the version from the filename) and change 2 strings inside the map file.
As for the map file, beside the changes in #20 there is no other change to that file, it's the same as what's linked in #21.
Comment #23
willzyx CreditAttribution: willzyx commented@alexpott
the patch looks good and the jquery.min.map is the same as http://code.jquery.com/jquery-2.1.4.min.map. The only changes are
Original:
"file":"jquery-2.1.4.min.js","sources":["jquery-2.1.4.js"]
Ours:
"file":"jquery.min.js","sources":["jquery.js"]
I think the problem is the way in which you run the diff. Using diff on a long one line file is problematic.. Use phpstorm files compare or try something like (stolen from here)
Comment #24
alexpottSorry for getting that wrong and thanks for explaining it. Committed 8c7d0f4 and pushed to 8.0.x. Thanks!