Protect user id 1

Could you provide the changes in a patch? By providing a modified version of a file, it's harder to find out what you actually modified, especially when the same file changes later in dev. See "Creating patches" on https://www.drupal.org/patch.

Here is a patch that adds protection for user 1. It prevents user 1 from being deleted via either the "Delete items" form or via the "delete non-existent" feature. Also attached a patch with tests only, to demonstrate that the tests are failing without the fix.

The feature for protecting certain roles is not included.

I think that when trying to delete user 1, while user 1 does not get deleted, the associated feeds item should get deleted. Else there would be no way to get rid of that redundant feeds item. New patch.

The feeds item doesn't have to be deleted when deleting non-existing users, I think. Only when really clearing a feed.

All tests are passing, not sure why the testbot moved the status to "Needs work". Back to "Needs review".

+++ b/plugins/FeedsUserProcessor.inc
@@ -379,6 +389,19 @@ class FeedsUserProcessor extends FeedsProcessor {
+    if (isset($state->removeList[1])) {
+      unset($state->removeList[1]);
+    }

I don't think this needs to be conditional.

Other than that, looks good!

@twistor
Thanks for reviewing. I see that a variable doesn't have to exist to unset it.

I fixed this and made a few tiny corrections in the tests (mainly text corrections). If this is passes, I'll commit it.

Committed #15.