Closed (fixed)
Project:
HTML Mail
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
7 May 2015 at 14:19 UTC
Updated:
11 Aug 2015 at 15:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
aron novakComment #2
aron novakEh, content-type definition is fixed here.
Comment #3
salvisThank you for your patch, Aron Novak — this looks reasonable and very useful!
Any reviewers/testers out there, please?
Comment #4
aron novakhttps://www.drupal.org/u/mr.york pointed out that #2 can fail because of https://bugs.php.net/bug.php?id=68776 with PHP 5.x or newer
https://github.com/yohgaki/php-src/commit/89def6911128d8806fd10957a01833...
So under headers array, we should not add trailing newlines.
Comment #5
mr.york commentedAttached EOL fix patch.
Comment #6
salvisThank you for the improved patch, mr.york!
The module name is spelt "Mail MIME" and it must NOT be translated.
Please remove the empty line.
I need a third party to review and test this patch — anyone, please!
Comment #7
aron novakRerolled and applied the requested change. I am far from 3rd party, but FYI we have this in production for a few weeks without any complaints.
Comment #8
salvisThanks!
What module(s) are you using for generating the emails? Are you by any chance using Subscriptions?
If you are, could this possibly be used for sending
[subs:items:index:#0:formatted]as per #2534276: How to send HTML notifications?Comment #10
Nafes commentedWorks perfectly for me. Just removed a redundant blank line near the end of changes. Thank you, Aron.
@salvis, can we mark the issue as fixed or you see some room for improvements?
Comment #11
salvis@Nafes: If it works, it's great!
I'm happy to see you come on board, but how did this happen? I don't see any issue about you getting maintainer access. Would you please post an issue with a few lines to introduce yourself, and also add your name on the front page? (and in Mail MIME, too)
Comment #12
Nafes commentedAs discussed, added my name on the front pages. Very happy to meet you, salvis!