Provide simple plain/text alternative without mailmime [#2484879]

Comment	File	Size	Author
#7	2484879-htmlmail-plain_text-6.patch	2.13 KB	Aron Novak

#5	2484879-htmlmail-plain_text-5.patch	2.13 KB	mr.york

#2	2484879-htmlmail-plain_text-2.patch	2.11 KB	Aron Novak

#1	2484879-htmlmail-plain_text-1.patch	2.12 KB	Aron Novak

Comment #2

Hungarian

Hungary, Budapest

CreditAttribution: Aron Novak commented 7 May 2015 at 14:36

File	Size
2484879-htmlmail-plain_text-2.patch	2.11 KB

Eh, content-type definition is fixed here.

Log in or register to post comments

Comment #3

salvis

he/his

CreditAttribution: salvis as a volunteer commented 2 June 2015 at 00:42

1 file was hidden/shown/deleted

File	Size
2484879-htmlmail-plain_text-1.patch	2.12 KB

Thank you for your patch, Aron Novak — this looks reasonable and very useful!

Any reviewers/testers out there, please?

Log in or register to post comments

Comment #4

Aron Novak

Hungarian

Hungary, Budapest

CreditAttribution: Aron Novak commented 17 July 2015 at 09:00

https://www.drupal.org/u/mr.york pointed out that #2 can fail because of https://bugs.php.net/bug.php?id=68776 with PHP 5.x or newer
https://github.com/yohgaki/php-src/commit/89def6911128d8806fd10957a01833...

So under headers array, we should not add trailing newlines.

Log in or register to post comments

Comment #5

mr.york CreditAttribution: mr.york commented 17 July 2015 at 09:25

File	Size
2484879-htmlmail-plain_text-5.patch	2.13 KB

Attached EOL fix patch.

Log in or register to post comments

Comment #6

salvis

he/his

CreditAttribution: salvis as a volunteer commented 18 July 2015 at 20:28

Thank you for the improved patch, mr.york!

+++ b/htmlmail.admin.inc
@@ -184,6 +184,16 @@ function htmlmail_admin_settings() {
+        '!mailmime' => l(t('Mailmime'), 'https://www.drupal.org/project/mailmime', array('attributes' => array('target' => '_blank'))),

The module name is spelt "Mail MIME" and it must NOT be translated.

+++ b/htmlmail.mail.inc
@@ -120,6 +120,21 @@ class HTMLMailSystem implements MailSystemInterface {
+

Please remove the empty line.

I need a third party to review and test this patch — anyone, please!

Log in or register to post comments

Comment #7

Aron Novak

Hungarian

Hungary, Budapest

CreditAttribution: Aron Novak commented 20 July 2015 at 19:47

File	Size
2484879-htmlmail-plain_text-6.patch	2.13 KB

Rerolled and applied the requested change. I am far from 3rd party, but FYI we have this in production for a few weeks without any complaints.

Log in or register to post comments

Comment #8

salvis

he/his

CreditAttribution: salvis as a volunteer commented 21 July 2015 at 17:51

Thanks!

What module(s) are you using for generating the emails? Are you by any chance using Subscriptions?

If you are, could this possibly be used for sending [subs:items:index:#0:formatted] as per #2534276: How to send HTML notifications?

Log in or register to post comments

Comment #10

Nafes CreditAttribution: Nafes as a volunteer commented 22 July 2015 at 18:54

Status:

Needs review

» Reviewed & tested by the community

Works perfectly for me. Just removed a redundant blank line near the end of changes. Thank you, Aron.

@salvis, can we mark the issue as fixed or you see some room for improvements?

Log in or register to post comments

I'm happy to see you come on board, but how did this happen? I don't see any issue about you getting maintainer access. Would you please post an issue with a few lines to introduce yourself, and also add your name on the front page? (and in Mail MIME, too)