Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I noticed a lot of issues when adding files with the plus botton in the breadcrumbs menu.
I marked them as major as I can not expect users to be able to fix the metadata of submitted files.
All the issues I noticed in 7.x-2.33, but I managed to reproduce the major one in 7.x-2.40
The major one is that when I submit a file via the plus button it does not get added to the group menu and does not appear in the Files & Folders Pane.
In the version 2.33 file submission has an extra step.
step 1: Browse/Upload
step 2: Set up: Name/File title, Save
step 3: Set up: File name/Title, Submit
I already had some testers being confused by that.
When I submit files in other ways the process seems to have one step less.
In the version 2.33 I noticed that users without space membership, had the plus button visible with Add File option. When pressed they could not upload files as they didn't have the permissions.
For contrast the space admin had two options available Add file in SectionName; Create Document Page in SectionName.
This error might be difficult to reproduce but there seem to be an inconsistency in the visibility rules for Add File and Create document buttons. See attached image.
In the version 2.33 if a file name is too long (I think it was longer than 256 chars) it still gets uploaded but it gets an error when being added to the group menu and ends up being lost. The expected behaviour should be an error on upload or the title cut to size automatically.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | image5.png | 37.53 KB | pgancarski |
| #3 | Image4.png | 24.4 KB | pgancarski |
| #3 | Image3.png | 62.39 KB | pgancarski |
| #3 | Image2.png | 18.9 KB | pgancarski |
| #3 | Image1.png | 44.75 KB | pgancarski |
Comments
Comment #1
pgancarski CreditAttribution: pgancarski commentedComment #2
mpotter CreditAttribution: mpotter commentedYou need to ensure that your Files section is enabled for the Group Menu. There was a bug in 2.33 that prevented this. New file sections in 2.40 get added to the menu properly.
So edit your existing Section page and click the Menu Link option, select "Group Menu" as the parent and click the Enabled checkbox. Then the files within that section will appear on the page.
As far as the steps:
1) Yes, click Browse
2) This step is to select the file from your local computer to upload
3) Then you are asked for the Title of this file. This allows you to give a human name to your filename. The default title is the same as the filename.
So those are the correct and proper steps to adding a file. Steps 2 & 3 are separated because in step 2 you can actually bulk-upload multiple files all at once and step 3 is needed to allow people to adjust the human titles of those files. You'll notice that when uploading a lot of files at once step #3 is very efficient and lets you change all of the titles on one page, rather than prompting for each file upload.
The distinction between "Add file" and "Add document page" is that Add File prompts you to upload a file and automatically creates the document page in the background to wrap the uploaded file (in previous versions you had to manually create the document page and then manually attach the file). The "Add document page" is intended for non-file web content, such as Wiki pages.
Both are controlled via the same "Create Document Page" permissions, however for the Add Files option you'll also need to check your global Drupal permissions and be sure your users are allowed to upload files. I could not reproduce the image showing the Add File option for users that didn't have the Create Document Page OG permission.
The file name upload size is a Drupal issue for file fields and not something we can fix in Open Atrium. The vast majority of users do not have filenames longer than 255 chars (and you shouldn't, that's why Atrium allows you to have a separate title and body description for your files so the actual machine filename can be shorter).
Comment #3
pgancarski CreditAttribution: pgancarski commentedThe major issue:
This bug is different than the bug when creating document sections.
I have a document section set up properly, but depending on how do I upload the files the -document- metadata gets set up correctly or not.
To reproduce in 2.40:
Image1: From the level of space use the plus button to "Add file in section_name"
Image2: The file is visible but in the wrong folder
Image3: When editing metadata of the file - group menu options are disabled
Image4: When I refresh the space view, the file disapears from the Documents Pane (It is still visible at the section level)
Image5: Group menu showing menu settings and files succesfully submitted via Files & Folders Pane.
------
The second issue - it is fixed in 2.40. File upload works in 2 steps and is the same no matter which button I use, so no complains here. Third issue - I will try to figure out where it is comming from and create a separate issue if I do. Last issue - I agree that using very long file names is pushing it, and yet it was the first thing that my client did :/
I wish I could do more than complaining about bugs, but I still need some know-how before I will be able to submit my own bug fixes.
Comment #4
mpotter CreditAttribution: mpotter commentedAh, I see the issue now. I pushed a fix in commit cebf2c0 for this. Should be just in time for the 2.40 release later today. It was just an issue when using the + button to add a file to a section. Our test scripts were testing with the Add File button on the file section itself.