As a companion to https://www.drupal.org/node/2123315, paging is broken with views_php-7.x-2.x-dev and views-7.x-3.11. 7.x-2.x-dev already seems to have the changes recommend in the 7.x-1.x issue but paging is broken. I've got this working in my site and it seems that all we need to do is get rid of update_wrapped_pager() in plugins/views/views_php_plugin_pager.inc

I don't know if that means anything about other functions being unnecessary but I'm including a patch to start with.

CommentFileSizeAuthor
#10 views_php-2484407-10.patch817 bytesñull
views_php_pager.patch866 bytesbkat

Comments

caspervoogt’s picture

caspervoogt commented

Patch works for me .. so far so good anyway.

sgp913’s picture

sgp913 commented

Same here, the previous patches kept driving CPU to 100% immediately crashing the server. Going for an hour now with no issues on medium traffic site.

Could someone please do more testing and commit this as soon as possible? This is a serious issue and bkat seems to have fixed it. :-)

orangutangle’s picture

orangutangle commented

Patch works for me, thanks bkat.

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Active » Needs review
Related issues: +#2276165: Pager disappears when Global: PHP used in Views 3.8
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Related issues: +#2123315: Pager does not appear if fields use Views PHP (7.x-1.x)
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented

@bkat I suggest to post your patch on issue #2123315 and close this one as a duplicate.

bkat’s picture

bkat commented

#2123315 is for 7.x-1-x-dev and this is 7.x-2.x-dev. I do know that the patches posted in there do not work on 7.x-2.x.

fizk’s picture

fizk commented

@bkat Can you comment on why update_wrapped_pager() can be removed without any ill effects?

bkat’s picture

bkat commented

Just empirical evidence from debugging the problem. I narrowed it down to that function, debugged the view and all the paging related data was correct and then was messed up by the function.

Most notably, there is no pager with that function and when its removed, the pager functions flawlessly.

Please note that I'm not using views_php for filtering, just for fields. It should probably tested with views_php filtering as well.

ñull’s picture

ñull commented
StatusFileSize
new views_php-2484407-10.patch817 bytes

The patch in #0 somehow did not apply here. I remade one here with GIT and attached it. Once applied the patch does what it promised to do.

It should probably tested with views_php filtering as well.

Would like to know if this is really a condition before we can give it the "Reviewed" status? If so, how would views_php filtering be best tested? May be the module should be extended with a testing module for this?

jkdeveyra’s picture

jkdeveyra commented

I tried the patch on views_php filtering and the pager shows up even there's no result found.

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
commented

#10 works for me, thanks

drupalshrek’s picture

drupalshrek commented

#10 (views_php-2484407-10.patch) works fine. Thanks!

drupalshrek’s picture

drupalshrek commented
Status: Needs review » Reviewed & tested by the community
nattyweb’s picture

nattyweb commented

I can confirm #10 worked for me too. Thank you.

elpino’s picture

elpino commented
Status: Reviewed & tested by the community » Needs review

Indeed the patch brings back pager and filtering works, but pagination is wrong... if a row is filtered out the page shows the wrong amount of rows.
Not sure if this is because of getting rid of the update_wrapped_pager() function though, but I think it is related.

peterlolty’s picture

peterlolty commented
Title: Views Pager is hidden (7.x-2.x) » Pager does not appear if fields use Views PHP (7.x-2.x)
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Closed (duplicate)

This is a duplicate of 2123315. So I close this one. We have to focus efforts on that one to get it commit for both branches.